fix: early return when incompatible data is sent #552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed an unused occurrence of this method. Signed-off-by: Louis Greiner <[email protected]>
emersion
reviewed
Oct 7, 2025
| this.nodesStore.nodes.forEach((node) => { | ||
| node.getPorts().forEach((port) => { | ||
| const oppositeNode = node.getOppositeNode(port.getTrainrunSection()); | ||
| if (oppositeNode === undefined) { |
There was a problem hiding this comment.
Hm, I don't think this should ever happen?
getOppositeNode() only returns undefined when the trainrun section doesn't start/end at the node. Here, since we're iterating over the node's ports, the trainrun section necessarily starts or ends at the node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use to have no type check for undefined node
Also removed an unused occurrence of this method.
Issues
Fixes OpenRailAssociation/osrd#13531
This could have been prevented if we had this config
Checklist