Skip to content

fix: early return when incompatible data is sent #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: early return when incompatible data is sent #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/app/services/data/node.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ export class NodeService implements OnDestroy {
this.nodesStore.nodes.forEach((node) => {
node.getPorts().forEach((port) => {
const oppositeNode = node.getOppositeNode(port.getTrainrunSection());
if (oppositeNode === undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I don't think this should ever happen?

getOppositeNode() only returns undefined when the trainrun section doesn't start/end at the node. Here, since we're iterating over the node's ports, the trainrun section necessarily starts or ends at the node.

return;
}
const portAlignments = VisAVisPortPlacement.placePortsOnSourceAndTargetNode(
node,
oppositeNode,
Expand Down
1 change: 0 additions & 1 deletion src/app/view/editor-main-view/data-views/trainrunsections.view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,7 +2133,6 @@ export class TrainrunSectionsView {

if (!this.editorView.isTemporaryDisableFilteringOfItemsInViewEnabled()) {
if (ts.getSourceNode().isNonStopNode()) {
const node = ts.getSourceNode().getOppositeNode(ts);
retPath = this.transformPathIfSourceNodeFilteredDueNonStopNodesFiltering(ts, retPath);
}
if (ts.getTargetNode().isNonStopNode()) {
Expand Down