-
Notifications
You must be signed in to change notification settings - Fork 46
Update ZipScript, added a parameter for runing .exe installers inside archives #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merged current master
Update the fork with changes from master fork.
Fork update
merge changes
Merging changes to the fork
Merging updates from master fork
Merging changes from master
Merge from master branch
Can you maybe test with some other free application so that we are not blocked by Photoshop? |
I could but I don't know any application other than Photoshop that would make use of ZipScript. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zemogiter the script requires some formatting
Add a file existence check.
@madoar is this the check sufficient? |
I think you should invert the check, i.e. add behavior in case the file does not exist. I think ideally we should show an error message informing the user of the problem. |
@madoar done |
I get using this that |
Can you show the exact error message? I'm assuming that a prefix is lost at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check that both cases still work (with and without setup path)?
I do not have time to review currently. |
Description
In it's current shape, the
ZipScript
dosen't do much because there is no information regarding the .exe file inside archive.What works
to be filled
What was not tested
Nothing was tested yet, waiting for @ImperatorS79 to test this in his Adobe Photoshop script #1122
Test
Ready for review
json-align
andeslint
run according to the documentation.