Add Photoshop

[Kreyren]

Based on https://appdb.winehq.org/objectManager.php?sClass=version&iId=37541

Depends on: #909 -> Resolved, Thanks @ImperatorS79 !
Depends on: #910 -> Resolved, Thanks @ImperatorS79 !
Depends on: #911 -> Resolved, Thanks @ImperatorS79 !
Depends on: #912 -> Resolved, Thanks @ImperatorS79 !
Blocked by: https://github.com/PhoenicisOrg/scripts/issues/1012 -> Created #1060
Blocked by: #1061 -> Concluded phoenicis-wine issue

Reference: https://www.playonlinux.com/en/app-3489.html

Signed-off-by: Jacob Hrbek [email protected]

[Kreyren]

Requesting adding multiple versions of photoshop in root of application so that end-user can pick which version they want insted of using Online.

[qparis]

This is not how we organized the scripts. We should have one different script per version.

[ImperatorS79]

Those verbs does not seem very difficult to implement, so @Kreyren I am sure you can do it based on other verbs 😉.

I would however prefer if someone that own Adobe Photoshop could test it under latest wine staging to be sure all those verbs are needed.

[Zemogiter]

@Kreyren atmlib, msxml3 and 6 are now part of the repo.

[Kreyren]

@Zemogiter Noted, will update once i can

[ImperatorS79]

@Kreyren There is now a font_smoothing plugin. Please also check travis and codacy.

[Kreyren]

@Kreyren There is now a font_smoothing plugin. Please also check travis and codacy.

is noted, will do once i have the time

[Kreyren]

Results in seemingly java issue https://gist.githubusercontent.com/Kreyren/a5dbad680b9b00bfcd1b188b882ae0b1/raw/63f90df524519070a441b8e567c6b7dd1d3a25f8/dsgadgsdag

help-wanted

EDIT: trying to fix codacy and travis

EDIT2: Same issue

[Kreyren]

main.png is missing

[ImperatorS79]

@Kreyren please test again with those modifications

[Zemogiter]

@ImperatorS79 missing { after OnlineInstaller

[ImperatorS79]

How ? In other scripts there is not that.

[Kreyren]

QA: It's forcing user-input for MSXML -> Silent install is preffered.

QA: Same for MSXML 6.0 Parser

[Kreyren]

Checksum changed for adobeair. -> Blocked by https://github.com/PhoenicisOrg/scripts/issues/1012 -> -> Created #1060

[madoar]

The script looks a bit strange to me. I mean you use an OnlineInstallerScript but don't use its core functionality, i.e. .url("http://url_to_exe").

@plata @qparis do you know whether the OnlineInstallerScript or ZipScript is able to comfortably do the following:

1. download a zip file
2. extract the zip file
3. execute an installer exe file inside the extracted zip file
4. create a shortcut to an exe file created by the installer file

[Zemogiter]

@madoar ZipScript

[madoar]

@Zemogiter https://phoenicisorg.github.io/scripts/Develop/script-js/ doesn't provide an example how this can be done. Can you add one?

[Zemogiter]

I could but I dont remember how to access the .Phoenicis/resources path where the file in url will be downloaded.

[plata]

The problem with this use case is that you must know the filename of the executable inside the script. As this cannot be determined automatically, I don't see an easy way to have the functionality in the QuickScripts. The ZipScript will extract the zip content in the container. You could of course use that in postInstall but I don't think you want the zip content there. So, unless you think this is a common use case, I would suggest to use a PlainInstaller.

[madoar]

It seems to me like a more common use-case. I guess a lot of applications try to compress their installers by first archiving it.

[plata]

We could enhance the OnlineInstallerScript and LocalInstallerScript. Maybe an optional parameter:

.executableInArchive("xyz.exe")

[madoar]

That sounds like a good idea.

[plata]

My only problem with this solution is that it increases the complexity of the QuickScript. Also it's not quite clear why it's in OnlineInstallerScript and not ZipScript (that would be possible as well).

[Zemogiter]

I'd say let's do this mod in ZipScript

[plata]

Ok. Basically adding a wine.run() after

scripts/Engines/Wine/QuickScript/Zip Script/script.js

Line 56 in 749c609

.extract();

should be enough.

[ImperatorS79]

@Kreyren Could you upload this file as the miniature ?

[ImperatorS79]

You can also test it by using #1121 and #1074 with this.

[Kreyren]

@Kreyren Could you upload this file as the miniature ?

I can't for legal reasons, sorry..

Note that i no longer contribute to phoenicis, but i keep the repositories up for others to remake the MR or finish it.

[ImperatorS79]

The image comes from wikipedia ans is stated as "public domain"...

[Kreyren]

The image comes from wikipedia ans is stated as "public domain"...

Referencing https://www.adobe.com/legal/permissions/trademarks.html

I wasn't able to confirm that said logo is released on wikipedia as public domain, but i nanycase said trademark is still in affect. This usage would be considered as fair use, but i'm not going to merge it on my name.

[ImperatorS79]

Okay then ^^.

[Kreyren]

Okay then ^^.

sorry >.>