-
Notifications
You must be signed in to change notification settings - Fork 0
[REFACTOR] 맵뷰컨트롤러 분리 #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[REFACTOR] 맵뷰컨트롤러 분리 #118
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ecbffa1
refactor/#110: RegisterVC View와 PopUpImagesColletionView로 분리
zzangzzangguy fadb4d7
refactor/#110: gitignore 업데이트
zzangzzangguy 5c0a2e4
refactor/#110: 임시저장
zzangzzangguy 1854d5e
fix/#110: 맵뷰컨트롤러 주석및 로거 정리
zzangzzangguy 293b3cc
refactor/#110: 주석및 로거 제거
zzangzzangguy ae89367
style/#110: Apply SwiftLint autocorrect
github-actions[bot] d665876
refactor/#109: MapViewController 클래스 선언부에서 MapUIHandling/MapInteracti…
zzangzzangguy 393cd18
feat/#109: MapInteractionHandling 프로토콜 정의 추가
zzangzzangguy 6296e47
feat/#109 : UIHandling 프로토콜 추가
zzangzzangguy 8719640
feat/#109: FullScreenMapViewController override 구문 분리
zzangzzangguy 5fa03b8
feat/#109: 개별마커별 사이즈 재설정
zzangzzangguy 49be7b6
style/#109: Apply SwiftLint autocorrect
github-actions[bot] db1c784
style/#110: Apply SwiftLint autocorrect
github-actions[bot] 57c1864
style/#110: Apply SwiftLint autocorrect
github-actions[bot] ff4f5b9
feat/#109 : UIHandling 프로토콜 추가
zzangzzangguy 471f1a1
feat/#109: 개별마커별 사이즈 재설정
zzangzzangguy 782d699
style/#109: Apply SwiftLint autocorrect
github-actions[bot] f84959b
fix/#109: 로딩인디케이터 로직 제거후 로딩상태 스테이트반영구문 제거
zzangzzangguy 0e6b92a
style/#109: Apply SwiftLint autocorrect
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 테스트 했던거 그대로 남아있어요!!
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DTO 제거 #117 에서 수정되었습니다 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 0 additions & 7 deletions
7
Poppool/Poppool/Domain/Repository/MapDirectionRepository.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
프로비저닝은 한번 설치되면 Xcode에 남으니 파일이랑 ignore도 지우셔도 될거같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제거되었습니다~