Fix for loop unrolling in qasm2 emit

[david-pl]

This bug was introduced with the new UnrollScf pass in kirin v0.17.23. It currently breaks the QASM2 GHZ example in the documentation.

@weinbe58 @Roger-luo I'm not entirely sure we still need the trim.UnusedYield here, all tests and examples work without it. Still, I left it in just to be sure.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
10872	9122	84%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
src/bloqade/qasm2/passes/fold.py	91%	🟢
TOTAL	91%	🟢

updated for commit: 0fff7fa by action🐍

[weinbe58]

@david-pl The one use case for having the Trim rewrite is to pair it with a LiftIf rewrite because you can safely lift any ssa result that is not within the yield of the IfElse bodies.

[weinbe58]

@david-pl do you want me to look at the GHZ example?

[david-pl]

The one use case for having the Trim rewrite is to pair it with a LiftIf rewrite because you can safely lift any ssa result that is not within the yield of the IfElse bodies.

@weinbe58 good to know, thanks.

@david-pl do you want me to look at the GHZ example?

What do you mean? I added the part that was not working as a unit test, is that not sufficient?

[david-pl]

Superseded by #536