Skip to content

Conversation

weinbe58
Copy link
Member

@weinbe58 weinbe58 commented Oct 8, 2025

Just doing some small housekeeping using the new passes/rewrite rules added in Kirin in the past few months.

@weinbe58 weinbe58 requested a review from david-pl October 8, 2025 15:01
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/bloqade/rewrite/passes/canonicalize_ilist.py 63.63% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Oct 8, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
10869 9153 84% 0% 🟢

New Files

File Coverage Status
src/bloqade/rewrite/passes/aggressive_unroll.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
src/bloqade/qasm2/passes/fold.py 100% 🟢
src/bloqade/rewrite/passes/_init_.py 100% 🟢
src/bloqade/rewrite/passes/canonicalize_ilist.py 69% 🟢
TOTAL 90% 🟢

updated for commit: 3951f43 by action🐍

@david-pl
Copy link
Collaborator

david-pl commented Oct 8, 2025

@weinbe58 I suppose this supersedes #525 , right? Could you port the unit test I added there to this PR as well to see if it works?

@weinbe58
Copy link
Member Author

weinbe58 commented Oct 8, 2025

Oh sorry! didn't mean to step on your toes but I need this pass to fix the issues with the qubit refactor with the CirqEmit infrastructure. Basically we need this aggressive unrolling in a lot of places and I can also use it inside shuttle after the new release!

@david-pl
Copy link
Collaborator

david-pl commented Oct 8, 2025

@weinbe58 no worries, that's not what I meant 😄

This PR is cleaner than my fix, so by all means let's use this one. FYI, I tried and it also fixes the issue I had in #525 .
Still, it would make sense to add this as unit test, I think, since it's still failing on main.

Copy link
Collaborator

@david-pl david-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinbe58 weinbe58 merged commit d079cc2 into main Oct 8, 2025
11 checks passed
@weinbe58 weinbe58 deleted the phil/refactor-old-passes branch October 8, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants