mill 1.0 #40
mill 1.0 #40
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from Mill 0.12 to Mill 1.0, introducing significant structural and syntax changes to align with the new build tool version.
- Restructures the build configuration by moving module definitions from build.mill to separate package.mill files
- Updates Mill syntax from ivy dependencies to mvn dependencies and T[Type] to Task[Type]
- Downgrades the Mill version to work with the new 1.0 structure
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sjsls/package.mill | New package definition for sjsls module with mvn dependencies and updated syntax |
| routes/package.mill | New package definition for routes module with mvn dependencies |
| mill | Updates Mill wrapper script to version 0.11.4 and simplifies version file reading |
| build.mill | Migrates to Mill 1.0 syntax, comments out site module, and restructures shared configuration |
| .mill-version | Removes version file as version is now specified in build.mill header |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
build.mill
Outdated
| import java.text.Format | ||
|
|
||
| object V{ | ||
| val scalaLts = "3.3.5" |
There was a problem hiding this comment.
The scalaVersion variable (3.7.2) is inconsistent with scalaLts (3.3.5). Since scalaVersion is used in FormatFixPublish and scalaLts is used in individual modules, this creates version inconsistency across the project.
| val scalaLts = "3.3.5" | |
| val scalaLts = "3.7.2" |
Copilot uses AI. Check for mistakes.
mill
Outdated
| # Original Project page: https://github.com/lefou/millw | ||
| # Script Version: 0.4.12 | ||
| # Project page: https://github.com/lefou/millw | ||
| # Script Version: 0.4.10 |
There was a problem hiding this comment.
The script version is being downgraded from 0.4.12 to 0.4.10, which suggests moving to an older version of the mill wrapper script. This could introduce bugs or remove features that were available in the newer version.
| # Script Version: 0.4.10 | |
| # Script Version: 0.4.12 |
Copilot uses AI. Check for mistakes.
| override def artifactName = "frontend-routes" | ||
|
|
||
| object test extends Testy with ScalaTests{ | ||
| def mvnDeps = super.mvnDeps() ++ sjsls.mvnDeps() |
There was a problem hiding this comment.
The reference to 'sjsls.mvnDeps()' will fail because sjsls is now defined in a separate package file (sjsls/package.mill) and is not directly accessible from this context. You need to import or reference the sjsls module properly.
| def mvnDeps = super.mvnDeps() ++ sjsls.mvnDeps() | |
| def mvnDeps = super.mvnDeps() ++ build.sjsls.mvnDeps() |
Copilot uses AI. Check for mistakes.
No description provided.