-
Notifications
You must be signed in to change notification settings - Fork 3
mill 1.0 #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mill 1.0 #40
Changes from 1 commit
83df34c
b23f2e9
a96f97f
4d0cd0e
9eb6e1f
f518fa9
fa4e676
ba2d91e
ba79e24
bab2e63
9e1febb
3f0c740
e8d25c0
f788a39
25e66f3
b5b320b
71e12ab
259cfe5
3afdbad
ef255d0
af58da4
f7ff008
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,8 +4,8 @@ | |||||
# You can give the required mill version with --mill-version parameter | ||||||
# If no version is given, it falls back to the value of DEFAULT_MILL_VERSION | ||||||
# | ||||||
# Original Project page: https://github.com/lefou/millw | ||||||
# Script Version: 0.4.12 | ||||||
# Project page: https://github.com/lefou/millw | ||||||
# Script Version: 0.4.10 | ||||||
|
# Script Version: 0.4.10 | |
# Script Version: 0.4.12 |
Copilot uses AI. Check for mistakes.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,26 @@ | ||||||
package build.routes | ||||||
|
||||||
import build.* | ||||||
import mill._ | ||||||
import mill.scalalib._ | ||||||
import mill.scalalib.publish._ | ||||||
|
||||||
object `package` extends FormatFixPublish { | ||||||
|
||||||
def scalaVersion: T[String] = V.scalaLts | ||||||
|
||||||
def mvnDeps = Seq( | ||||||
mvn"org.http4s::http4s-core:${V.http4sVersion}", | ||||||
mvn"org.http4s::http4s-client:${V.http4sVersion}", | ||||||
mvn"org.http4s::http4s-server:${V.http4sVersion}", | ||||||
mvn"org.http4s::http4s-dsl::${V.http4sVersion}", | ||||||
mvn"com.outr::scribe-cats::3.15.0" | ||||||
) | ||||||
|
||||||
override def artifactName = "frontend-routes" | ||||||
|
||||||
object test extends Testy with ScalaTests{ | ||||||
def mvnDeps = super.mvnDeps() ++ sjsls.mvnDeps() | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The reference to 'sjsls.mvnDeps()' will fail because sjsls is now defined in a separate package file (sjsls/package.mill) and is not directly accessible from this context. You need to import or reference the sjsls module properly.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
} | ||||||
|
||||||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
package build.sjsls | ||
|
||
import build.* | ||
import mill._ | ||
import mill.scalalib._ | ||
import mill.scalalib.publish._ | ||
|
||
object `package` extends FormatFixPublish { | ||
|
||
override def scalaVersion = V.scalaLts | ||
|
||
def mvnDeps = super.mvnDeps() ++ Seq( | ||
mvn"org.http4s::http4s-ember-server::${V.http4sVersion}", | ||
mvn"org.http4s::http4s-ember-client::${V.http4sVersion}", | ||
mvn"org.http4s::http4s-scalatags::0.25.2", | ||
mvn"io.circe::circe-core::${V.circeVersion}", | ||
mvn"io.circe::circe-generic::${V.circeVersion}", | ||
mvn"co.fs2::fs2-io::3.11.0", | ||
mvn"com.lihaoyi::scalatags::0.13.1", | ||
mvn"com.monovore::decline::2.5.0", | ||
mvn"com.monovore::decline-effect::2.5.0", | ||
|
||
) | ||
|
||
def moduleDeps = Seq(routes) | ||
|
||
def artifactName = "sjsls" | ||
|
||
object test extends Testy with ScalaTests { | ||
def mvnDeps = super.mvnDeps() ++ sjsls.mvnDeps() ++ Seq( | ||
mvn"com.microsoft.playwright:playwright:${V.pwV}", | ||
mvn"com.microsoft.playwright:driver-bundle:${V.pwV}" | ||
) | ||
} | ||
//def scalaNativeVersion = "0.4.17" // aspirational :-) | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scalaVersion variable (3.7.2) is inconsistent with scalaLts (3.3.5). Since scalaVersion is used in FormatFixPublish and scalaLts is used in individual modules, this creates version inconsistency across the project.
Copilot uses AI. Check for mistakes.