-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: useQwikRouter #7731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: build/v2
Are you sure you want to change the base?
feat: useQwikRouter #7731
Conversation
🦋 Changeset detectedLatest commit: 74f2757 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This only affects starters/adapters right? Existing code shouldn't be affected? |
0334ce6
to
00c0bad
Compare
@maiieul indeed everything should keep working. The only API change is that the qwikPlugin normalizeOptions now returns a Promise but that's pretty much an internal API, it wasn't even documented. |
9dd9943
to
64b11a5
Compare
this makes it possible to put the routerhead in root as well
This allows colocating the headers and root, to make it easier to understand what's going on, and to make it more intuitive to change.
Currently blocked on #7747