Skip to content

feat: useQwikRouter #7731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: build/v2
Choose a base branch
from
Open

feat: useQwikRouter #7731

wants to merge 1 commit into from

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Jul 15, 2025

This allows colocating the headers and root, to make it easier to understand what's going on, and to make it more intuitive to change.

Currently blocked on #7747

@wmertens wmertens requested review from a team as code owners July 15, 2025 18:22
Copy link

changeset-bot bot commented Jul 15, 2025

🦋 Changeset detected

Latest commit: 74f2757

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Varixo Varixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Jul 15, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 74f2757

@maiieul
Copy link
Contributor

maiieul commented Jul 16, 2025

This only affects starters/adapters right? Existing code shouldn't be affected?

@wmertens wmertens force-pushed the useqwikrouter branch 2 times, most recently from 0334ce6 to 00c0bad Compare July 20, 2025 06:54
@wmertens wmertens changed the title feat: useQwikRouter feat: useQwikRouter, refactor build configuration Jul 20, 2025
@wmertens
Copy link
Member Author

@maiieul indeed everything should keep working. The only API change is that the qwikPlugin normalizeOptions now returns a Promise but that's pretty much an internal API, it wasn't even documented.

this makes it possible to put the routerhead in root as well
@wmertens wmertens changed the title feat: useQwikRouter, refactor build configuration feat: useQwikRouter Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants