ed448-goldilocks: assorted fixes and improvements #1302
Merged
+27
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was wondering why this PR looks so big. But I just forgot to rebase it on top of #1300. |
daxpedda
changed the title
daxpedda
changed the title
Merged
tarcieri
reviewed
Jul 20, 2025
tarcieri
reviewed
Jul 20, 2025
tarcieri
reviewed
Jul 20, 2025
Comment on lines
-279
to
+278
| fn square_n(&self, mut n: u32) -> FieldElement { | ||
| let mut result = self.square(); | ||
| fn square_n<const N: u32>(&self) -> FieldElement { |
There was a problem hiding this comment.
Curious if this change actually impacts codegen in any way (i.e. for the better)
There was a problem hiding this comment.
I didn't check the codegen, but I benchmarked the inversion method and there were no changes.
There was a problem hiding this comment.
Feels kind of six of one, half dozen of another in that case
There was a problem hiding this comment.
I made this change to prevent accidental variable time usage.
But let me know and I can just remove it.
tarcieri
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some assorted fixes and improvements from #1291.
They are split into descriptive commits for your convenience.