Frame Shift Module to Correct Timing in Data - PR For Spring Production

[VCLanNguyen]

Description

New module for timing reconstruction in introduced at reco2 in sbndcode.
Module make data products that are saved in CAF as new Standard Record products.
Data Timing variables in CAF, i.e. crt space point time, sbnd crt track time, opflash and opt0, are shifted for beam spill reconstruction.
Full description can be found in docdb: https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090

• Have you added a label? (bug/enhancement/physics etc.)

• Have you assigned at least 1 reviewer?

• Is this PR related to an open issue / project?

• Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.

• Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  sbnobj 2025A: Frame Shift Module to Correct Timing in Data - PR For Spring Production sbnobj#141
  sbnanaobj 2025A: Frame Shift Module to Correct Timing in Data - PR For Spring Production sbnanaobj#155
  sbndcode 2025A: Frame Shift Module to Correct Timing in Data - PR For Spring Production sbndcode#803
  sbncode 2025A: Frame Shift Module to Correct Timing in Data - PR For Spring Production #563

• Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

[PetrilloAtWork]

There is a bug in need to be fixed.

In addition, I am raising a design issue (in the sense of "controversy" rather than "flaw") with respect to the use of caf::SRTrigger. The flame is in the old PR #562. As I see it, there are two parts to it:

• not filling caf::SRTrigger: this has an immediate impact on the produced samples, and I would like it to be discussed immediately before proceeding;
• using separate code for shifting times: this is about implementation internals (two pieces of code doing the same thing) and can be discussed in parallel without blocking this PR.

[VCLanNguyen]

There is a bug in need to be fixed.

In addition, I am raising a design issue (in the sense of "controversy" rather than "flaw") with respect to the use of caf::SRTrigger. The flame is in the old PR #562. As I see it, there are two parts to it:

* not filling `caf::SRTrigger`: this has an immediate impact on the produced samples, and I would like it to be discussed immediately before proceeding;

* using separate code for shifting times: this is about implementation internals (two pieces of code doing the same thing) and can be discussed in parallel without blocking this PR.

I will create an issue on sbncode to address the second point. I think to converge SBND and ICARUS timing correction in caf, more testing is needed.
Issue: #567

[PetrilloAtWork]

Approved!

[kjplows]

trigger build ci_ref=v10_06_02 LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnobj#141 SBNSoftware/sbnanaobj#155 SBNSoftware/sbn*@release/SBN2025A SBNSoftware/sbndcode@v10_06_03

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard