Skip to content

Conversation

@asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Sep 2, 2025

Description

This PR adds new attributes to the TPCPMTBarycenterFM objects to store the chi2 and score that is used to perform matching after the upgrades to the algorithm. (SBNSoftware/sbndcode#807)

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

This PR is to be merged with
SBNSoftware/sbnanaobj#156

Copy link
Contributor

@linyan-w linyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@fjnicolas fjnicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Any reason to not add the Angle variable to the CAFs as well?

@linyan-w linyan-w moved this to Reviewer Approved in SBND 2025 Fall Production Sep 16, 2025
@kjplows kjplows moved this from Open pull requests to Partially reviewed in SBN software development Sep 16, 2025
@nathanielerowe
Copy link
Contributor

nathanielerowe commented Sep 17, 2025

@JosiePaton @PetrilloAtWork Does this look ok to you?
edit: see also
SBNSoftware/sbnanaobj#156
SBNSoftware/sbnobj#144

@kjplows kjplows moved this from Partially reviewed to Urgent checks in SBN software development Sep 17, 2025
@kjplows
Copy link
Contributor

kjplows commented Sep 17, 2025

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Urgent checks to To merge in SBN software development Sep 17, 2025
@kjplows kjplows merged commit fc26e0a into develop Sep 18, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Sep 18, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Sep 18, 2025
@linyan-w linyan-w moved this from Reviewer Approved to In tagged release in SBND 2025 Fall Production Sep 18, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done
Status: In tagged release

Development

Successfully merging this pull request may close these issues.

9 participants