Feature/acastill tpcpmt bfm upgrade #807
Conversation
|
@fjnicolas Can you take a look at this? |
fjnicolas
left a comment
fjnicolas
left a comment
There was a problem hiding this comment.
Thanks @asanchezcastillo ! Looks good to me
| void GetPCA(std::vector<double> const& x, std::vector<double> const& y, std::vector<double> const& weight, std::vector<double>& PCA ); ///< Get the PCA | ||
| double GetSliceCharge(const std::vector<art::Ptr<recob::Hit>> &tpcHitsVec, const detinfo::DetectorPropertiesData det_prop, int tpc); | ||
| double GetFlashLight(double flash_pe, std::vector<double>& total_dir_visibility, std::vector<double>& total_ref_visibility); | ||
| void CreateOpHitList( std::vector<art::Ptr<recob::OpHit>> ophitlist, std::vector<double>& ophit_z, std::vector<double>& ophit_y, std::vector<double>& ophit_weight); |
There was a problem hiding this comment.
Why not use FlashPE_v so you do not need to load all the OpHits??
|
trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbncode#565 SBNSoftware/sbnalg@v10_09_00 SBNSoftware/sbnobj#144 SBNSoftware/sbnanaobj#156 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_01 SBNSoftware/sbnd_data@v01_35_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Approved |
nathanielerowe
moved this from Ready for CI
to RM Approved
in SBND 2025 Fall Production
nathanielerowe
moved this from RM Approved
to Wait for next release
in SBND 2025 Fall Production
nathanielerowe
moved this from Wait for next release
to Ready for CI
in SBND 2025 Fall Production
nathanielerowe
moved this from Ready for CI
to In tagged release
in SBND 2025 Fall Production
Description
This PR introduces changes to the TPCPMTBarycenter flash matching algorithm to improve its performance. In particular, it makes use of the directionality of the charge/light footprints and a very naive light-calorimetry that is used along with the separation between the charge/light barycenter to build a chi2 that is used to perform charge/light matching.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
This PR is to be merged after:
SBNSoftware/sbncode#565
SBNSoftware/sbnanaobj#156
SBNSoftware/sbnobj#144
Link(s) to docdb describing changes (optional)
https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=42327&filename=RecoMeeting_16_07.pdf&version=1
Is there a docdb describing the issue this solves or the feature added?