Skip to content

Conversation

@asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Sep 2, 2025

Description

This PR introduces a new object CorrectedOpFlashTiming that stores the OpFlash time after different corrections to improve timing resolution are applied. (More information on the sbndcode PR SBNSoftware/sbndcode#813)

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

This PR is to be merged with:
SBNSoftware/sbnobj#140
SBNSoftware/sbnanaobj#157

@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Sep 17, 2025
@kjplows
Copy link
Contributor

kjplows commented Sep 17, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbnanaobj#157 SBNSoftware/sbnobj#140

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 18, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 18, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 18, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 18, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 18, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 18, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 18, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 18, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 18, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 18, 2025
@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows
Copy link
Contributor

kjplows commented Sep 18, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbnanaobj#157 SBNSoftware/sbnobj#140

@kjplows kjplows moved this from Testing to Urgent checks in SBN software development Sep 18, 2025
@kjplows
Copy link
Contributor

kjplows commented Sep 18, 2025

Multiple CI checks fail, but none of them are related to this PR -- the CI workflow fails to pull SBNSoftware/sbnobj#140 into the CI. @vitodb any ideas what's happening there?

Checked local build, builds okay both on its own and with the other PRs for this release merged in.
Since issue SBNSoftware/sbnanaobj#160 is active, I'll open an issue for this PR.

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Urgent checks to To merge in SBN software development Sep 18, 2025
@kjplows kjplows merged commit 8e7e088 into develop Sep 18, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Sep 18, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Sep 18, 2025
@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@linyan-w linyan-w moved this from Waiting on Reviewer to In tagged release in SBND 2025 Fall Production Sep 18, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done
Status: In tagged release

Development

Successfully merging this pull request may close these issues.

5 participants