Add lightpropagationcorrection module #813

asanchezcastillo · 2025-09-08T14:49:40Z

Description

This PR implements a new module for applying light propagation corrections to OpFlash timing based on TPC information. It does select the OpFlash matched to every slice and correct the time of the flash based on the space points in the slice. After the correction, a new object CorrectedOpFlash is created as well to store the new timing information, namely:

The original time of the flash
The time of the neutrino at the upstream wall obtained using light-only corrections
The time of the neutrino at the upstream wall obtained using neutrino time of flight correction from the TPC vertex
The time of the neutrino at the upstream wall obtained using neutrino time of flight correction from the TPC vertex and the light propagation time from the TPC spacepoints.
This new object is also associated to its father slice and OpFlash. The module supports the use of the OpT0Finder and BarycenterFM tools for initial charge/light matching though the latter is used by default as it is a model-independent tool.
The module is included on reco2_data.fcl to be run as a part of the standard reconstruction workflow.

This PR requires merging of the following PRs:
#807
SBNSoftware/sbnobj#140
SBNSoftware/sbnanaobj#157
SBNSoftware/sbncode#566

Checklist

Added at least 1 label from available labels.
Assigned at least 1 reviewer under Reviewers,
Assigned all contributers including yourself under Assignees
Linked any relevant issues under Developement
Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
Does this affect the standard workflow?
Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?
https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=42327

lynnt20 · 2025-09-10T14:11:39Z

hi @asanchezcastillo , just snooping around here, is there any reason we wouldn't want OpT0Finder to inherit the corrected OpFlashes?

asanchezcastillo · 2025-09-10T16:29:43Z

Hi @lynnt20 ! I have chosen BFM as the default option because both FMs have shown very similar matching efficiency with a handscanned neutrino sample (https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=42327), which translates into a very similar timing reconstruction performance (I can share the plots in private). Furthermore, since the BFM is model-independent I believe it will be less affected by any changes that may happen in the future to our simulation.
In any case, I do not have a strong preference and if people would benefit from having both, we can run the module twice, once with each FM tool.

fjnicolas

@asanchezcastillo this looks great and will be extremely useful to have for the next production!

I spotted a few unused functions/variables that could be dropped. The two more critical things:

SPEC TDC is a must to the module, so it shouldn't be configurable
There may be some conflict with the ReadoutDelay variable?

In addition to that, I think it may be useful to also save OpFlash t0 without any correction at all (right now it has the light propagation time using eta_PMT by default). In that way we could isolate each of the constributions to the timing correction at the analysis level. That would me adding an additional member to the PR in sbnobj though. I know we are in a tight schedule, so this request should NOT prevent this PR moving forward into production.

sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.cc

fjnicolas · 2025-09-11T18:01:18Z

sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.cc

+double sbnd::LightPropagationCorrection::GetFlashT0(double flash_time, std::vector<recob::OpHit> ophitlist){
+
+    std::vector< std::pair<double, double> > selected_hits;
+    double pe_sum = 0;
+
+    // fill vector with selected hits in the specified window
+    for(auto const& hit : ophitlist) {
+      if( hit.PeakTime()<flash_time+fPostWindow && hit.PeakTime()>flash_time-fPreWindow && hit.PE()>fMinHitPE){
+        selected_hits.push_back( std::make_pair(hit.PE(), hit.PeakTime()));
+        pe_sum += hit.PE();
+      }
+    }
+
+    if(pe_sum>0){
+      // sort vector by number of #PE (ascending order)
+      std::sort( selected_hits.begin(), selected_hits.end(), std::greater< std::pair<double, double> >() );
+
+      double flasht0_mean=0., pe_count=0.;
+      int nophits=0;
+
+      // loop over selected ophits
+      for (size_t ix=0; ix<selected_hits.size(); ix++) {
+        pe_count += selected_hits[ix].first;
+        flasht0_mean += selected_hits[ix].second;
+        nophits++;
+        if( pe_count/pe_sum>fPDFraction ) break;
+      }
+      return flasht0_mean/nophits;
+    }
+    else
+      return flash_time;
+}


Do you need this function? You are using the one from the flash tools

Indeed! Thanks for the catch:)

sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.hh

fjnicolas · 2025-09-11T18:13:20Z

sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.cc

+        if(_sliceMaxNuScore<fNuScoreThreshold){
+            ResetSliceInfo();
+            continue; // Skip to the next slice if the nu score is below threshold
+        }


Is this cut really needed here? Why not letting this module do the corrections for all the neutrino slices and let the analyzer place the cut?

The main reason behind this choice is the computing time required to run over all the slices. Placing the cut here avoids running over slices that are clearly not neutrinos, which alleviates computing time.

sbndcode/LightPropagationCorrection/job/sbnd_lightpropagationcorrection_config.fcl

sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.hh

sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.cc

JosiePaton

I see Fran has left a lot of good comments here, but for the sake of time I'll add my approval now for the change to the Standard Record pending discussion of his suggested changes :)

…_module.cc Co-authored-by: Francisco Javier Nicolás-Arnaldos <[email protected]>

asanchezcastillo · 2025-09-11T19:26:37Z

@fjnicolas thanks a lot for the thorough review! I have removed the unused variables as well as the readout delay correction, which is not needed at this point. Given the tight schedule, I'll incorporate the modifications to the module once the production release is cut.

fjnicolas

Thanks for the quick turnaround! All the changes look ok. Happy to work on another iteration for a future patch.

nathanielerowe · 2025-09-18T20:51:49Z

@asanchezcastillo Let me know if that merge commit looks incorrect. There was a conflict, but it seemed pretty simple so I resolved it.

nathanielerowe · 2025-09-18T23:58:14Z

trigger build ci_ref=v10_10_02 LArSoft/lar*@LARSOFT_SUITE_v10_10_03 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 SBNSoftware/sbncode@v10_10_03

FNALbuild · 2025-09-19T00:01:46Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-09-19T00:11:03Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-09-19T00:13:33Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-09-19T00:22:02Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-09-19T00:35:38Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

…default

nathanielerowe · 2025-09-19T14:23:22Z

trigger build ci_ref=v10_10_02 LArSoft/lar*@LARSOFT_SUITE_v10_10_03 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 SBNSoftware/sbncode@v10_10_03

FNALbuild · 2025-09-19T14:35:24Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-09-19T14:44:28Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-09-19T14:45:26Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-09-19T15:06:35Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

Add lightpropagationcorrection module

813278a

asanchezcastillo mentioned this pull request Sep 8, 2025

Feaature/acastill light propagation #802

Closed

7 tasks

asanchezcastillo added 2 commits September 8, 2025 10:02

Add lightpropagationcorrection to cafmaker

7eeae8c

Fix bugs and cleanup

57a7018

asanchezcastillo mentioned this pull request Sep 8, 2025

Feature/acastill corrected opflash SBNSoftware/sbncode#566

Merged

6 tasks

asanchezcastillo requested review from fjnicolas, ggamezdiego and linyan-w September 8, 2025 17:07

asanchezcastillo self-assigned this Sep 8, 2025

asanchezcastillo added the enhancement New feature or request label Sep 8, 2025

asanchezcastillo added this to SBND 2025 Fall Production Sep 8, 2025

asanchezcastillo requested a review from JosiePaton September 8, 2025 17:07

asanchezcastillo marked this pull request as ready for review September 8, 2025 17:08

asanchezcastillo moved this to Todo in SBND 2025 Fall Production Sep 8, 2025

fjnicolas reviewed Sep 11, 2025

View reviewed changes

JosiePaton approved these changes Sep 11, 2025

View reviewed changes

asanchezcastillo and others added 2 commits September 11, 2025 21:06

Update sbndcode/LightPropagationCorrection/LightPropagationCorrection…

0fa8598

…_module.cc Co-authored-by: Francisco Javier Nicolás-Arnaldos <[email protected]>

Cleanup and remove unused functions/variables

95c3aef

fjnicolas approved these changes Sep 11, 2025

View reviewed changes

nathanielerowe moved this from Todo to Reviewer Approved in SBND 2025 Fall Production Sep 11, 2025

nathanielerowe moved this from Reviewer Approved to Ready for CI in SBND 2025 Fall Production Sep 11, 2025

ggamezdiego approved these changes Sep 12, 2025

View reviewed changes

Merge branch 'develop' into feature/acastill_correctedOpFlash

1ac4e5b

nathanielerowe moved this from Ready for CI to Wait for next release in SBND 2025 Fall Production Sep 16, 2025

nathanielerowe moved this from Wait for next release to Ready for CI in SBND 2025 Fall Production Sep 16, 2025

Merge branch 'develop' into feature/acastill_correctedOpFlash

bd0baa2

Merge branch 'develop' into feature/acastill_correctedOpFlash

e193266

SBNSoftware deleted a comment from FNALbuild Sep 18, 2025

swap reco2_data.fcl module for possible ci fix

0e017a6

SBNSoftware deleted a comment from FNALbuild Sep 18, 2025

check nuscore exists before accessing and not produce output file by …

7d35f35

…default

Merge branch 'develop' into feature/acastill_correctedOpFlash

393d10b

nathanielerowe merged commit 09a13f5 into develop Sep 19, 2025

nathanielerowe moved this from Ready for CI to In tagged release in SBND 2025 Fall Production Sep 19, 2025

Add lightpropagationcorrection module #813

Add lightpropagationcorrection module #813

Uh oh!

Conversation

asanchezcastillo commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Relevant PR links (optional)

Link(s) to docdb describing changes (optional)

Uh oh!

lynnt20 commented Sep 10, 2025

Uh oh!

asanchezcastillo commented Sep 10, 2025

Uh oh!

fjnicolas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fjnicolas Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

asanchezcastillo Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fjnicolas Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

asanchezcastillo Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JosiePaton left a comment

Choose a reason for hiding this comment

Uh oh!

asanchezcastillo commented Sep 11, 2025

Uh oh!

fjnicolas left a comment

Choose a reason for hiding this comment

Uh oh!

nathanielerowe commented Sep 18, 2025

Uh oh!

nathanielerowe commented Sep 18, 2025

Uh oh!

FNALbuild commented Sep 19, 2025

Uh oh!

FNALbuild commented Sep 19, 2025

Uh oh!

FNALbuild commented Sep 19, 2025

Uh oh!

FNALbuild commented Sep 19, 2025

Uh oh!

FNALbuild commented Sep 19, 2025

Uh oh!

nathanielerowe commented Sep 19, 2025

Uh oh!

FNALbuild commented Sep 19, 2025

Uh oh!

FNALbuild commented Sep 19, 2025

Uh oh!

FNALbuild commented Sep 19, 2025

Uh oh!

FNALbuild commented Sep 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

asanchezcastillo commented Sep 8, 2025 •

edited

Loading