prevent crash in ViewScreenshotService when image data is null
#3579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a crash in
ViewScreenshotServiceoccurring on iOS.The Issue
When
screenshotOfViewWithTag:is called on a view that cannot be rendered (e.g. it has a frame of {0,0}, is not currently visible, or the app is in the background), theUIGraphicsImageRenderermay return a validUIImageobject but with aNULL CGImageor empty data.Attempting to call
CGDataProviderCopyDataon a null provider, or subsequentlyCFDataGetLengthon a nulldataRef, results in a hard crash (typicallyEXC_BAD_ACCESSorCF_IS_OBJCinside CoreFoundation).The Fix
Added explicit null checks for:
image.CGImagedataRefreturned byCGDataProviderCopyDataIf either is
null, the method now safely returnsnullptr, allowing the JS side to handle the failure gracefully, instead of crashing the native runtime.