Skip to content

prevent crash in ViewScreenshotService when image data is null #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

prevent crash in ViewScreenshotService when image data is null #3579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/skia/apple/ViewScreenshotService.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ - (instancetype)initWithUiManager:(RCTUIManager *)uiManager {

// Convert from UIImage -> CGImage -> SkImage
CGImageRef cgImage = image.CGImage;
if (!cgImage) {
return nullptr;
}

// Get some info about the image
auto width = CGImageGetWidth(cgImage);
Expand All @@ -59,6 +62,9 @@ - (instancetype)initWithUiManager:(RCTUIManager *)uiManager {
// Convert from UIImage -> SkImage, start by getting the pixels directly from
// the CGImage:
auto dataRef = CGDataProviderCopyData(CGImageGetDataProvider(cgImage));
if (!dataRef) {
return nullptr;
}
auto length = CFDataGetLength(dataRef);
void *data = CFDataGetMutableBytePtr((CFMutableDataRef)dataRef);

Expand Down
Loading