Skip to content

Conversation

timea-solid
Copy link
Member

@timea-solid timea-solid commented Sep 3, 2025

This is work done to improve different aspects of the library:

  • droppen node 18
  • from commonsjs to ESM
  • better and state of the art configs
  • generation of a solid-logic.js (UMD and ESM) file for direct web usage (powered by webpack)
  • version info
  • clean dependencies

@timea-solid timea-solid requested a review from Copilot September 4, 2025 07:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the library architecture by migrating from CommonJS to ESM modules, updating build configuration, and improving development practices. The changes include converting string quotes to single quotes, removing unnecessary semicolons, and establishing a proper TypeScript/ESM build pipeline.

  • Migration from CommonJS to ES modules with updated imports/exports
  • Updated build toolchain with Rollup, improved ESLint configuration, and TypeScript compilation
  • Code style standardization to single quotes and removal of semicolons

Reviewed Changes

Copilot reviewed 40 out of 44 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Updated to ESM module type, new build scripts, and modern dependencies
rollup.config.js New Rollup configuration for bundling ESM output
eslint.config.js Modern ESLint configuration with TypeScript support
tsconfig.test.json New TypeScript configuration for test files
timestamp.sh New script for generating version information
src/**/*.ts Updated imports to single quotes and removed semicolons
test/**/*.ts Updated imports, quote style, and added ESLint disable comments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@timea-solid timea-solid requested a review from Copilot September 12, 2025 08:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 43 out of 47 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants