-
Notifications
You must be signed in to change notification settings - Fork 8
Improved library #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improved library #100
Changes from 55 commits
908c8cf
92ca4c6
e5f3f7d
f9d5d21
cc7e1b6
f51524a
b095cf0
47c4eab
616b9f9
183049d
74baf17
22c8d8a
8e431bd
78ce629
75b5e6d
c3986c3
3e818fd
caa433a
66a8779
4ce7677
e3fbc78
42252ae
a4b452e
6d50cf3
29d7a0d
08b6da4
1c3e6ea
c188582
509ddc5
e368b0b
1c75a86
8f392e6
7898142
a31646a
cdc50bb
98332e2
cfdb831
786a33e
ecb4985
1d92309
45245b2
b176235
2e1ed31
da65b2c
f7eee1f
696775b
f480b7d
bc0ea8f
dbb83f7
6fd7192
536a3ae
d167ace
28e29fd
db26ace
3343cc7
aa7c1ee
aa437e5
8d8bb43
6b04155
a8299b5
d73b3bc
a826b8a
71ea328
1cf90c6
86b6bac
f3e6173
a44ca66
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,6 @@ jobs: | |
| strategy: | ||
| matrix: | ||
| node-version: | ||
| - 18.x | ||
| - 20.x | ||
| - 22.x | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| node_modules | ||
| lib | ||
| dist | ||
| coverage | ||
|
|
||
| ### VisualStudioCode Patch ### | ||
| # Ignore all local history of files | ||
| .history | ||
| .idea | ||
| .vscode | ||
|
|
||
| src/versionInfo.ts | ||
| src/versionInfo.ts |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| export default { | ||
| presets: [ | ||
| ['@babel/preset-env', { targets: { node: 'current' } }], | ||
| '@babel/preset-typescript' | ||
| ] | ||
| } | ||
timea-solid marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,49 @@ | ||||
| import tsParser from '@typescript-eslint/parser' | ||||
| import tseslintPlugin from '@typescript-eslint/eslint-plugin' | ||||
| import importPlugin from 'eslint-plugin-import' | ||||
|
|
||||
| export default [ | ||||
| { | ||||
| ignores: [ | ||||
| 'dist/**', | ||||
| 'node_modules/**', | ||||
| 'coverage/**' | ||||
| ], | ||||
| }, | ||||
| { | ||||
| files: ['src/**/*.js', 'src/**/*.ts', 'src/**/*.cjs', 'src/**/*.mjs'], | ||||
| languageOptions: { | ||||
| parser: tsParser, | ||||
| parserOptions: { | ||||
| project: ['./tsconfig.json'], | ||||
| sourceType: 'module', | ||||
| }, | ||||
| }, | ||||
| plugins: { | ||||
| '@typescript-eslint': tseslintPlugin, | ||||
| import: importPlugin, | ||||
| }, | ||||
| rules: { | ||||
| semi: ['error', 'never'], | ||||
| quotes: ['error', 'single'], | ||||
| 'no-unused-vars': 'off', // handled by TS | ||||
| '@typescript-eslint/no-unused-vars': ['warn'], | ||||
|
||||
| '@typescript-eslint/no-unused-vars': ['warn'], |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,17 @@ | ||
| module.exports = { | ||
| verbose: true, | ||
| /** @type {import('jest').Config} */ | ||
| export default { | ||
| // verbose: true, // Uncomment for detailed test output | ||
| collectCoverage: true, | ||
| coverageDirectory: 'coverage', | ||
| testEnvironment: 'jsdom', | ||
| testEnvironmentOptions: { | ||
| customExportConditions: ['node'] | ||
| customExportConditions: ['node'], | ||
| }, | ||
| setupFilesAfterEnv: [ | ||
| './test/helpers/setup.ts' | ||
| ] | ||
| } | ||
| testPathIgnorePatterns: ['/node_modules/', '/dist/'], | ||
| transform: { | ||
| '^.+\\.[tj]sx?$': ['babel-jest', { configFile: './babel.config.js' }], | ||
| }, | ||
| setupFilesAfterEnv: ['./test/helpers/setup.ts'], | ||
| testMatch: ['**/__tests__/**/*.ts?(x)', '**/?(*.)+(spec|test).ts?(x)'], | ||
| roots: ['<rootDir>/src', '<rootDir>/test'], | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename "dist/solid-logic.esm.external.js" mentioned in the documentation doesn't match the actual webpack output filenames which are "solid-logic.esm.js" and "solid-logic.esm.min.js" (without "external" in the name). This will confuse users trying to use the library.