Skip to content

Conversation

YoshiRulz
Copy link
Member

@YoshiRulz YoshiRulz commented Jul 26, 2025

See Fluent homepage and my notes #64.
edit: Marked as draft again because I wanted a POC for actually localising the app, but when I tried that I ran into some bugs in Mono that will have to be worked around, as well as some problems with the code I've written.

If someone on Windows could check the Designer inlining matches the previous layout, those can be pushed to master immediately. Will do later, in the meantime here's a cleaner diff view.

@Morilli

This comment was marked as off-topic.

@vadosnaprimer

This comment was marked as off-topic.

@YoshiRulz

This comment was marked as off-topic.

@YoshiRulz YoshiRulz marked this pull request as ready for review July 27, 2025 18:52
@Morilli
Copy link
Collaborator

Morilli commented Jul 27, 2025

we'll have to stop using it anyway as part of leaving WinForms.

That's true and fine, but it doesn't look like that's what you're doing in here. Is using fluent not possible while keeping the existing structure?

@YoshiRulz
Copy link
Member Author

To keep the Designer files, I would have to move every .Text assignment into the ctor, similar to this:

public RamWatch()
{
InitializeComponent();
newToolStripMenuItem.Image = Resources.AddWatch;
EditContextMenuItem.Image = Resources.Cut;
RemoveContextMenuItem.Image = Resources.Delete;
DuplicateContextMenuItem.Image = Resources.Duplicate;
SplitContextMenuItem.Image = Resources.Split;
PokeContextMenuItem.Image = Resources.Poke;
FreezeContextMenuItem.Image = Resources.Freeze;
UnfreezeAllContextMenuItem.Image = Resources.Unfreeze;
InsertSeperatorContextMenuItem.Image = Resources.InsertSeparator;
MoveUpContextMenuItem.Image = Resources.MoveUp;
MoveDownContextMenuItem.Image = Resources.MoveDown;
MoveTopContextMenuItem.Image = Resources.MoveTop;
MoveBottomContextMenuItem.Image = Resources.MoveBottom;
ErrorIconButton.Image = Resources.ExclamationRed;
newToolStripButton.Image = Resources.NewFile;
openToolStripButton.Image = Resources.OpenFile;
saveToolStripButton.Image = Resources.SaveAs;
newWatchToolStripButton.Image = Resources.AddWatch;
editWatchToolStripButton.Image = Resources.Cut;
cutToolStripButton.Image = Resources.Delete;
clearChangeCountsToolStripButton.Image = Resources.Placeholder;
duplicateWatchToolStripButton.Image = Resources.Duplicate;
SplitWatchToolStripButton.Image = Resources.Split;
PokeAddressToolBarItem.Image = Resources.Poke;
FreezeAddressToolBarItem.Image = Resources.Freeze;
seperatorToolStripButton.Image = Resources.InsertSeparator;
moveUpToolStripButton.Image = Resources.MoveUp;
moveDownToolStripButton.Image = Resources.MoveDown;
NewListMenuItem.Image = Resources.NewFile;
OpenMenuItem.Image = Resources.OpenFile;
SaveMenuItem.Image = Resources.SaveAs;
RecentSubMenu.Image = Resources.Recent;
NewWatchMenuItem.Image = Resources.Find;
EditWatchMenuItem.Image = Resources.Cut;
RemoveWatchMenuItem.Image = Resources.Delete;
DuplicateWatchMenuItem.Image = Resources.Duplicate;
SplitWatchMenuItem.Image = Resources.Split;
PokeAddressMenuItem.Image = Resources.Poke;
FreezeAddressMenuItem.Image = Resources.Freeze;
InsertSeparatorMenuItem.Image = Resources.InsertSeparator;
MoveUpMenuItem.Image = Resources.MoveUp;
MoveDownMenuItem.Image = Resources.MoveDown;
MoveTopMenuItem.Image = Resources.MoveTop;
MoveBottomMenuItem.Image = Resources.MoveBottom;
Icon = ToolIcon;

@YoshiRulz YoshiRulz marked this pull request as draft August 6, 2025 02:50
@YoshiRulz YoshiRulz added Request: Feature/Enhancement For feature requests or possible improvements App: DiscoHawk Relating to DiscoHawk tool Meta Relating to code organisation or to things that aren't code labels Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: DiscoHawk Relating to DiscoHawk tool Meta Relating to code organisation or to things that aren't code Request: Feature/Enhancement For feature requests or possible improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants