DSDA Lua script #4464
Draft
DSDA Lua script #4464
+2,084
−735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Misc domain may have to wait until I gather feedback from Doom people. |
YoshiRulz
added
Request: Feature/Enhancement
kalimag
force-pushed
the
pr/dsda-lua-module
branch
from
96725d2 to
5cc4472
Compare
cleanup
Also reorder code to minimize reads for mobjs that aren't displayed
Lua doesn't have unsigned longs, but the signedness doesn't matter for flags and pointers anyway
kalimag
force-pushed
the
pr/dsda-lua-module
branch
from
7a7f2aa to
56267ec
Compare
|
I think center zoom is done. Not 100% perfect but combined with mouse drag feels sufficient. |
| local COUNTITEM_COLOR = false -- 0xA0FFFFFF | ||
| local ITEM_COLOR = false -- 0xA0FFFFFF | ||
| local MISC_COLOR = false -- 0xFFFFFFFF | ||
| local INERT_COLOR = false -- 0x80808080 |
There was a problem hiding this comment.
I recommend a Colors table.
| dsda.LINE_SIZE = 256 -- sizeof(line_t) is 232, but we padded it for niceness | ||
| dsda.MOBJ_SIZE = 512 -- sizeof(mobj_t) is 464, but we padded it for niceness | ||
| dsda.PLAYER_SIZE = 1024 -- sizeof(player_t) is 729, but we padded it for niceness | ||
| dsda.SECTOR_SIZE = 512 -- sizeof(sector_t) is 344, but we padded it for niceness |
There was a problem hiding this comment.
Maybe a Sizes table for these too?
| local read_u8 = memory.read_u8 | ||
| local read_u24 = memory.read_u24_le | ||
| local read_u32 = memory.read_u32_le | ||
| local readfloat = memory.readfloat |
There was a problem hiding this comment.
Similar shortcuts exist in the main script, looks like it makes sense to declare them once and then use everywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(continued from #4458)
TODO:
Ideally you can write code like
for mobj in pairs(dsda.mobjs) do print(mobj.type) endand all the memory reading is abstracted awayObjectscache inthings-lines.lua(doesn't work with spawned objects)Seems to be a big performance cost on fancy Hexen maps
If time permits:
gui.textworkscc @vadosnaprimer
Check if completed: