Skip to content

Conversation

@Simrayz
Copy link
Contributor

@Simrayz Simrayz commented Oct 10, 2025

Scope and purpose

This is a base PR, which individual upgrades are branched out from. This is done to lessen the reviewer load.

This PR upgrades jQuery to version v3.7.1 and its dependencies to their latest compatible version.

Should resolve #2291.

EDIT: 22.10.25: #3612 and #3613 have been approved, but won't be merged until this PR is approved.

  graph TB;
      A(#3582: Base jQuery Upgrade PR)
      B(#3612: jQuery Multiselect upgrade)
      C(#3613: jQuery UI upgrade)
      A-->B;
      A-->C;
Loading

How to test

Sparklines

Interface browser

  1. Open Interface browser tool
  2. Search for a device in the device select
  3. Fetch interfaces
  4. Select "Column visibility", and select one or more of: "OutOctets", "InOctets", "OutErrors", "InErrors".
  5. Verify that a chart is rendered in the column (it might be flat, because there is not data)

Room racks

  1. Search for a room that has sensors
  2. Open "Sensors in racks"
  3. Add a sensor to a rack, e.g. a temperature sensor
    • If there are no racks, make sure to create one first.
  4. Verify that the graph area renders. Might not actually show anything if your local graphite has no data.

IP Device Jobs

  1. Search for an IP Device (netbox)
  2. Verify that the "Jobs" table contains sparklines

Subnet Matrix

  1. Open /report/matrix
  2. Click on either a ipv4 or ipv6 scope
  3. Click on a subnet, and verify that a popover is rendered with a graph
    (or an empty box saying "No data from Graphite")

Tablesorter

Arnold

  1. Open "Arnold" tool
  2. Select "History tab" (/arnold/history)
  3. Verify that headers are sortable - note: If there are no identities in the database, the sorting is not activated (per the arnold.js plugin). For convenience, see attached image for a working table with mock identities.
image

Other tools

  • Thresholds: Verify that the table is sortable.
  • User and API administration: Verify that tables in "API Token List" and "JWT API Token List" can be sorted.

jQuery "load" function update

SeedDB

  1. Open "Seed DB" tool, navigate to "Service" page, and add a new service.
  2. Verify that "Search for IP device" is functional by searching for a device.

Geomap

  1. Open "Geomap" tool.
  2. Verify that the map loads correctly.

SeedDB: Management Profile

  1. Open "Seed DB" tool, navigate to "Management profile" page
  2. Select a protocol, e.g. "SNMPv3", and verify that the configuration form is updated.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@Simrayz Simrayz self-assigned this Oct 10, 2025
@Simrayz Simrayz added upgrade javascript dependencies Pull requests that update a dependency file labels Oct 10, 2025
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Test results

    27 files      27 suites   45m 33s ⏱️
 2 702 tests  2 702 ✅ 0 💤 0 ❌
20 006 runs  20 006 ✅ 0 💤 0 ❌

Results for commit 609bb60.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.95%. Comparing base (ce9853f) to head (609bb60).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3582   +/-   ##
=======================================
  Coverage   62.95%   62.95%           
=======================================
  Files         611      611           
  Lines       45150    45150           
  Branches       43       43           
=======================================
  Hits        28422    28422           
  Misses      16718    16718           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch 4 times, most recently from c4fb60a to f8d43d0 Compare October 14, 2025 09:52
@Simrayz Simrayz changed the base branch from master to chore/replace-timepicker-library October 14, 2025 09:53
@Simrayz Simrayz mentioned this pull request Oct 14, 2025
10 tasks
@Simrayz Simrayz force-pushed the chore/replace-timepicker-library branch from 328c5c1 to 46560fd Compare October 15, 2025 13:25
@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch from f8d43d0 to 05f9671 Compare October 15, 2025 13:27
@Simrayz Simrayz force-pushed the chore/replace-timepicker-library branch from 46560fd to 18cb958 Compare October 15, 2025 14:05
@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch from 05f9671 to b233fe4 Compare October 15, 2025 14:06
@Simrayz Simrayz force-pushed the chore/replace-timepicker-library branch 2 times, most recently from b0bf7de to d0c9d04 Compare October 16, 2025 13:02
@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch from b233fe4 to 2d03d3b Compare October 16, 2025 22:03
@Simrayz Simrayz changed the base branch from chore/replace-timepicker-library to master October 16, 2025 22:06
@Simrayz Simrayz changed the base branch from master to chore/replace-timepicker-library October 17, 2025 11:24
@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch 2 times, most recently from 2d41177 to 3a9eb45 Compare October 17, 2025 11:31
@Simrayz Simrayz mentioned this pull request Oct 17, 2025
10 tasks
@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch from 3a9eb45 to 1784f24 Compare October 17, 2025 12:10
@Simrayz Simrayz mentioned this pull request Oct 17, 2025
10 tasks
@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch 2 times, most recently from ff7a839 to 332494d Compare October 17, 2025 13:49
@Simrayz Simrayz deleted the branch master October 17, 2025 14:00
@Simrayz Simrayz closed this Oct 17, 2025
@Simrayz Simrayz reopened this Oct 17, 2025
@Simrayz Simrayz changed the base branch from chore/replace-timepicker-library to master October 17, 2025 14:06
@Simrayz Simrayz marked this pull request as ready for review October 22, 2025 12:05
@Simrayz Simrayz requested a review from a team October 23, 2025 09:09
@sonarqubecloud
Copy link

@Simrayz
Copy link
Contributor Author

Simrayz commented Oct 24, 2025

Merged #3612 and #3613, as they were approved. The only commits related to this PR are the ones without jQuery UI or Multiselect in the name.

@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch from 34d1bb6 to 609bb60 Compare December 2, 2025 09:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

@Simrayz
Copy link
Contributor Author

Simrayz commented Dec 2, 2025

@hmpf @lunkwill42 Any objections against merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vulnerability warnings for jQuery < v3.5.0

3 participants