Skip to content

Conversation

@emreariyurek
Copy link
Contributor

Since rippled has its own error codes, all occurrences have been replaced except for PR2549, and the entry has also been removed entirely from Clio’s error enum. This modification follows the feedback provided in this comment: #2549 (comment)

Pending compatible libxrpl — temporarily on hold

@godexsoft godexsoft added the on hold For issues that currently wait on other issues label Oct 13, 2025
@mathbunnyru mathbunnyru removed the on hold For issues that currently wait on other issues label Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.86%. Comparing base (b534570) to head (b676fb6).

Files with missing lines Patch % Lines
src/rpc/handlers/VaultInfo.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2661      +/-   ##
===========================================
+ Coverage    81.82%   81.86%   +0.04%     
===========================================
  Files          380      380              
  Lines        14313    14313              
  Branches      7901     7901              
===========================================
+ Hits         11712    11718       +6     
+ Misses        1439     1432       -7     
- Partials      1162     1163       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mathbunnyru
mathbunnyru previously approved these changes Nov 18, 2025
@kuznetsss
Copy link
Collaborator

Looks good, thanks!
But why don't we have to change any tests? I think it would be good to add some tests (in this PR or create an issue and do it in a separate PR).

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :rage1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants