fix: Make onSendMessage() handling less aggressive

[kabir]

Record the failure in the Task, unless it is in a final state, and return the Task to the user like before the last change.

[gemini-code-assist]

Summary of Changes

Hello @kabir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the error handling mechanism within the onMessageSend method. The primary goal is to make the system's response to processing failures less aggressive. Instead of abruptly terminating with an InternalError, the system now captures exceptions, records the failure details directly into the Task object, and marks the task as FAILED if it hasn't reached a final state. This ensures that the task's status accurately reflects any issues encountered and that the task is always returned to the user for inspection, providing a more robust and informative user experience.

Highlights

• Improved Error Handling: The onMessageSend method now handles exceptions more gracefully by recording failures within the Task object rather than immediately throwing an InternalError.
• Task State Update on Failure: If an error occurs during task processing and the task is not already in a final state, its status is explicitly updated to FAILED with a detailed error message.
• Consistent Task Return: The Task object is now consistently returned to the user, even in cases of failure, allowing the caller to inspect the task's final (potentially failed) state.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the error handling in onMessageSend to be less aggressive. Instead of throwing an InternalError for certain exceptions, it now records the failure within the Task by setting its state to FAILED and including an error message. This is a good improvement for robustness. My review includes a couple of suggestions to refine this new logic, focusing on ensuring unique message IDs for error messages and removing commented-out code for better clarity.