Skip to content

library/spi_engine, library/util_sigma_delta_spi: remove spi active #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

library/spi_engine, library/util_sigma_delta_spi: remove spi active #1885

wants to merge 1 commit into from

Conversation

LBFFilho
Copy link
Contributor

Remove the active signal from the SPI Engine, which was used in util_sigma_delta_spi as a necessary condition to generating triggers. This signal was the last vestige that made the use of the SPI Engine SYNC instruction necessary. Now this instruction is completely optional.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@LBFFilho
library/spi_engine, library/util_sigma_delta_spi: remove spi active
fdb69be 
Remove the active signal from the SPI Engine, which was used in
util_sigma_delta_spi as a necessary condition to generating triggers. This
signal was the last vestige that made the use of the SPI Engine SYNC instruction
necessary. Now this instruction is completely optional.

Signed-off-by: Laez Barbosa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan will be requested when the pull request is marked ready for review IuliaCMoldovan is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier will be requested when the pull request is marked ready for review gastmaier is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop will be requested when the pull request is marked ready for review StancaPop is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi will be requested when the pull request is marked ready for review sarpadi is a code owner

@podgori podgori Awaiting requested review from podgori podgori will be requested when the pull request is marked ready for review podgori is a code owner

@ladace ladace Awaiting requested review from ladace ladace will be requested when the pull request is marked ready for review ladace is a code owner

@PIoandan PIoandan Awaiting requested review from PIoandan PIoandan will be requested when the pull request is marked ready for review PIoandan is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021 PopPaul2021 will be requested when the pull request is marked ready for review PopPaul2021 is a code owner

@acostina acostina Awaiting requested review from acostina acostina will be requested when the pull request is marked ready for review acostina is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav will be requested when the pull request is marked ready for review AndreiGrozav is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LBFFilho