Add device tree for ADAQ23875. Add one lane support for CN0577 #2860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make two lanes the default mode. Signed-off-by: Iulia Moldovan <[email protected]>
The default configuration is still two-lane mode. To change to one-lane mode, the "adi,use-one-lane;" attribute needs to be specified. Signed-off-by: Iulia Moldovan <[email protected]>
- Support for ADAQ23876 is possible if the compatible in this dts is changed to "adaq23876". - Support for ADAQ23878 can be found at arch/arm/boot/dts/xilinx/zynq-zed-adv7511-cn0577.dts, by changing the compatible to "adaq23878". The default configuration is two-lane mode (without specifying any attribute). To change to one-lane mode, the "adi,use-one-lane;" attribute needs to be specified. Signed-off-by: Iulia Moldovan <[email protected]>
IuliaCMoldovan
requested review from
nunojsa,
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
13 tasks
gastmaier
reviewed
Jul 28, 2025
drivers/iio/adc/ltc2387.c
Outdated
Comment on lines
228
to
231
| } else { | ||
| ltc->lane_mode = TWO_LANES; | ||
|
|
||
| return ltc2387_set_sampling_freq(ltc, 15 * MHz); | ||
| return ltc2387_set_sampling_freq(ltc, 15 * MHz); | ||
| } |
There was a problem hiding this comment.
Can you remove this else?
After an if return, you don't need it and reviewers upstream will ask for this change
There was a problem hiding this comment.
Done in a separate commit. Will squash it after review
Signed-off-by: Iulia Moldovan <[email protected]>
|
Added a separate device tree for ADAQ23878. The differences between this one and the CN0577 one, are:
@gastmaier, I'm not sure if this is the right approach; or instead, should I include the CN0577 dts into the ADAQ23878 and just overwrite the oscillator frequency and the compatible? And leave the labels with "LTC2387"? This way there will be less code. |
Will squash after review. Signed-off-by: Iulia Moldovan <[email protected]>
IuliaCMoldovan
force-pushed
the
add_adaq2387x
branch
from
8ccc854 to
04fc46b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
PR Type
PR Checklist