Skip to content

Update session cookie name due to upcoming server change #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update session cookie name due to upcoming server change #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Shrine/app/src/main/java/com/authentication/shrine/utility/Constants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
package com.authentication.shrine.utility

object Constants {
const val SESSION_ID_KEY = "SESAME_SESSION_COOKIE="
const val SESSION_ID_KEY = "__Secure-SESAME_SESSION_COOKIE="
Copy link

@gemini-code-assist gemini-code-assist bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This constant SESSION_ID_KEY is also defined in Shrine/wear/src/main/java/com/authentication/shrinewear/network/AuthNetworkClient.kt. Duplicating constants across different modules can lead to maintenance issues and inconsistencies. If this value needs to be updated in the future, it must be changed in multiple places, which is error-prone.

To improve this, consider creating a shared Gradle module (e.g., :common or :core) that both the :app and :wear modules can depend on. You could then define SESSION_ID_KEY once in this shared module and use it across the project. This adheres to the Don't Repeat Yourself (DRY) principle and improves long-term maintainability.

}
2 changes: 1 addition & 1 deletion Shrine/wear/src/main/java/com/authentication/shrinewear/network/AuthNetworkClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class AuthNetworkClient {
/**
* The key used for the session ID cookie.
*/
internal const val SESSION_ID_KEY = "SESAME_SESSION_COOKIE="
internal const val SESSION_ID_KEY = "__Secure-SESAME_SESSION_COOKIE="
}

init {
Expand Down