fix(ios): handle video transcoding cancel exception #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbru31
requested changes
Jan 27, 2020
guillem-sopra
force-pushed
the
fix/handle-video-transcoding-cancel-exception
branch
2 times, most recently
from
3cf3cf5 to
cddc838
Compare
guillem-sopra
force-pushed
the
fix/handle-video-transcoding-cancel-exception
branch
from
cddc838 to
6dce381
Compare
guillem-sopra
force-pushed
the
fix/handle-video-transcoding-cancel-exception
branch
from
73abf9e to
9b66430
Compare
|
Great! I'll give this a review and try tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #545
If the video transcoding process is interrupted (generally by the user), an empty string is returned as file uri.