Skip to content

fix(ios): handle video transcoding cancel exception #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(ios): handle video transcoding cancel exception #549

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f06bef
fix(ios): handle video transcoding cancel exception
guimarca Jan 18, 2020
6dce381
fix(resultForVideo): pass exception message to cordova callback
guimarca Apr 12, 2020
9b66430
fix(resultForVideo): expection reason
guimarca Apr 12, 2020
97e09b9
Merge branch 'master' into fix/handle-video-transcoding-cancel-exception
timbru31 Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/ios/CDVCamera.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,12 +631,17 @@ - (void)resultForImage:(CDVPictureOptions*)options info:(NSDictionary*)info comp

- (CDVPluginResult*)resultForVideo:(NSDictionary*)info
{
NSString* moviePath = [[info objectForKey:UIImagePickerControllerMediaURL] absoluteString];
// On iOS 13 the movie path becomes inaccessible, create and return a copy
if (IsAtLeastiOSVersion(@"13.0")) {
moviePath = [self createTmpVideo:[[info objectForKey:UIImagePickerControllerMediaURL] path]];
@try {
NSString* moviePath = [[info objectForKey:UIImagePickerControllerMediaURL] absoluteString];
// On iOS 13 the movie path becomes inaccessible, create and return a copy
if (IsAtLeastiOSVersion(@"13.0")) {
moviePath = [self createTmpVideo:[[info objectForKey:UIImagePickerControllerMediaURL] path]];
}
return [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsString:moviePath];
} @catch (NSException *exception) {
NSLog(@"Camera.resultForVideo: error retrieving file path");
return [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsString:[exception reason]];
}
return [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsString:moviePath];
}

- (NSString *) createTmpVideo:(NSString *) moviePath {
Expand Down