Update datafusion-testing pin to update expected output for extended tests #17490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to merge apache/datafusion-testing#12 first and then update this PR |
adriangb
approved these changes
Sep 10, 2025
|
I merged the datafusion-testing PR I am verifying the extended tests one more time locally: INCLUDE_SQLITE=true nice cargo test --profile release-nonlto --test sqllogictests |
|
passed locally ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
extended tests are failing on main as DataFusion is now correctly running many more queries
What changes are included in this PR?
datafusion-testingpin to get Update expected output for coalsece short-circuit datafusion-testing#12Are these changes tested?
I tested them locally
Are there any user-facing changes?
No, these are dev / testing changes only