fix(lines): fix effect symbol flip on unidirectional loop end when roundTrip is not enabled
#21320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idirectional loop. close apache#20216
|
Thanks for your contribution! |
|
you should not change the code style.（indentation） |
…p' into fix-20216 fix(effectLine): fix symbol flicker at the ends when roundTrip is not enabled (resolves apache#20216)
plainheart
changed the title
roundTrip is not enabled
plainheart
changed the title
roundTrip is not enabledroundTrip is not enabled
sorry about that, my editor auto-formatted the file. i'll make sure to avoid next time. |
plainheart
approved these changes
Oct 24, 2025
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes an unwanted visual glitch where the effect symbol briefly reverses direction at the endpoint when using unidirectional looping animation in series-lines
Fixed issues
#20216
Details
Before: What was the problem?
In unidirectional loop mode (roundTrip: false), the symbol (arrow) briefly flipped its direction backward for a single frame upon reaching the end of the path (t=1), creating an unwanted visual 'flash' before resetting to the origin.
Screen.Recording.2025-10-17.at.2.27.46.PM.mov
After: How does it behave after the fixing?
The symbol now maintains its forward direction and rotation smoothly until the loop resets, eliminating the brief directional flip and ensuring a consistent unidirectional animation.
Screen.Recording.2025-10-17.at.2.37.08.PM.mov
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information