Skip to content

fix(lines): fix effect symbol flip on unidirectional loop end when roundTrip is not enabled #21320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2025
Merged

fix(lines): fix effect symbol flip on unidirectional loop end when roundTrip is not enabled #21320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5056eed
fix(lines): Prevent effect arrow from flipping direction at end of un…
mynk2611 Oct 17, 2025
a9aaed0
Merge remote-tracking branch 'remotes/origin/fix/effect-line/roundTri…
plainheart Oct 24, 2025
a86f464
test(lines): add test case for effect symbol flip
plainheart Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/chart/helper/EffectLine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ class EffectLine extends graphic.Group {
const p1 = symbol.__p1;
const p2 = symbol.__p2;
const cp1 = symbol.__cp1;
const t = symbol.__t < 1 ? symbol.__t : 2 - symbol.__t;
const t = symbol.__t <= 1 ? symbol.__t : 2 - symbol.__t;
const pos = [symbol.x, symbol.y];
const lastPos = pos.slice();
const quadraticAt = curveUtil.quadraticAt;
Expand All @@ -216,9 +216,9 @@ class EffectLine extends graphic.Group {
pos[1] = quadraticAt(p1[1], cp1[1], p2[1], t);

// Tangent
const tx = symbol.__t < 1 ? quadraticDerivativeAt(p1[0], cp1[0], p2[0], t)
const tx = symbol.__t <= 1 ? quadraticDerivativeAt(p1[0], cp1[0], p2[0], t)
: quadraticDerivativeAt(p2[0], cp1[0], p1[0], 1 - t);
const ty = symbol.__t < 1 ? quadraticDerivativeAt(p1[1], cp1[1], p2[1], t)
const ty = symbol.__t <= 1 ? quadraticDerivativeAt(p1[1], cp1[1], p2[1], t)
: quadraticDerivativeAt(p2[1], cp1[1], p1[1], 1 - t);


Expand Down
6 changes: 3 additions & 3 deletions src/chart/helper/EffectPolyline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class EffectPolyline extends EffectLine {

// Override
protected _updateSymbolPosition(symbol: ECSymbolOnEffectLine) {
const t = symbol.__t < 1 ? symbol.__t : 2 - symbol.__t;
const t = symbol.__t <= 1 ? symbol.__t : 2 - symbol.__t;
const points = this._points;
const offsets = this._offsets;
const len = points.length;
Expand Down Expand Up @@ -107,8 +107,8 @@ class EffectPolyline extends EffectLine {
symbol.x = p0[0] * (1 - p) + p * p1[0];
symbol.y = p0[1] * (1 - p) + p * p1[1];

const tx = symbol.__t < 1 ? p1[0] - p0[0] : p0[0] - p1[0];
const ty = symbol.__t < 1 ? p1[1] - p0[1] : p0[1] - p1[1];
const tx = symbol.__t <= 1 ? p1[0] - p0[0] : p0[0] - p1[0];
const ty = symbol.__t <= 1 ? p1[1] - p0[1] : p0[1] - p1[1];
symbol.rotation = -Math.atan2(ty, tx) - Math.PI / 2;

this._lastFrame = frame;
Expand Down
107 changes: 77 additions & 30 deletions test/lines-symbol.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.