monkeypatchingly fix #14331 by restarting vnc container (geb) #14995
+158
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: proof of bug
jdaugherty
reviewed
Aug 20, 2025
There was a problem hiding this comment.
Thank you @JonasPammer & Great Work Around!
My only concern is not cleaning up the recordings - can we clean those up unless some setting is set? Otherwise, running grails tests locally will constantly add more recordings.
| //} | ||
| tasks.withType(Test).configureEach { | ||
| systemProperty('grails.geb.recording.mode', 'RECORD_ALL') | ||
| systemProperty('grails.geb.recording.restartPerTest', 'true') |
There was a problem hiding this comment.
Can we add a doLast { } and remove the recordings after a test run? Otherwise it will continually add them every run locally.
cbmarcum
reviewed
Aug 21, 2025
| @@ -64,6 +65,7 @@ class GrailsGebSettings { | |||
| recordingFormat = VncRecordingFormat.valueOf( | |||
| System.getProperty('grails.geb.recording.format', DEFAULT_RECORDING_FORMAT.name()) | |||
| ) | |||
| recordingRestartPerTest = Boolean.parseBoolean(System.getProperty('grails.geb.recording.restartPerTest', false.toString())) | |||
There was a problem hiding this comment.
@jdaugherty @jamesfredley Since this is correcting default behavior that is unwanted. Should this be enabled by default so current build files without the new setting start working correctly?
|
@JonasPammer Thank you for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original, Upstream Open Issue: testcontainers/testcontainers-java#3998
The other upstream solution that was suggested, i.e. testcontainers/testcontainers-java#577, seemed way out of bound / too big of a change (that also relies on internals and commands, i.e. volitale to flv.py changes) to hack into here
i also tried a non-reflection attempt, i.e. to manage an own vnc and disable the container's interbound one -- https://gitkraken.dev/link/drafts/3d723754-a136-45c9-bb6f-8cad74600a88?type=patch. but decided to commit this here for comments.
i know reflection code will have a low chance. but at least this also contains a test one could add with Spock-Annotation of "Fails right now".
Edit: Closes #14331