-
-
Notifications
You must be signed in to change notification settings - Fork 967
Restart Geb VNC Container for each Test in a Spec to get correct recordings #14995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2b9e084
test: proof of bug
JonasPammer 724036a
chore: boolean toggle
JonasPammer 27388b0
fix using reflection
JonasPammer 305e430
test: improve clarity of test
matrei 60cdc68
fix: rename property for clarity
matrei 0b1929f
feat: default to restarting the recording container
matrei a27b47c
chore: cleanup
matrei 4eb7bc6
fix: remove redundant system property setting
matrei e220055
test(geb): clean up old recording directories
matrei 19dfb65
Merge branch '7.0.x' into jonas-issue-14331
jamesfredley 2226151
Restore Slf4j logging to WebDriverContainerHolder
jamesfredley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
...-test-examples/geb/src/integration-test/groovy/org/demo/spock/PerTestRecordingSpec.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.demo.spock | ||
|
|
||
| import grails.plugin.geb.ContainerGebSpec | ||
| import grails.testing.mixin.integration.Integration | ||
|
|
||
| @Integration | ||
| class PerTestRecordingSpec extends ContainerGebSpec { | ||
|
|
||
| void 'first test'() { | ||
| when: 'visiting the home page' | ||
| go('/') | ||
|
|
||
| then: 'the page loads correctly' | ||
| title.contains('Welcome to Grails') | ||
| } | ||
|
|
||
| void 'second test'() { | ||
| when: 'visiting another page' | ||
| go('https://grails.apache.org/') | ||
|
|
||
| and: 'ensuring file size is different' | ||
| Thread.sleep(1000) | ||
|
|
||
| then: 'the page loads correctly' | ||
| title.contains('Grails') | ||
| } | ||
|
|
||
| void 'verify last recording directory'() { | ||
| when: | ||
| // Logic from GrailsGebSettings | ||
| String recordingDirectoryName = System.getProperty('grails.geb.recording.directory', 'build/gebContainer/recordings') | ||
| File baseRecordingDir = new File(recordingDirectoryName) | ||
|
|
||
| then: 'base recording directory should exist' | ||
| baseRecordingDir.exists() | ||
|
|
||
| when: 'get most recent recording directory' | ||
| // Find the timestamped recording directory (should be the most recent one) | ||
| File recordingDir = null | ||
| File[] timestampedDirs = baseRecordingDir.listFiles({ File dir -> | ||
| dir.isDirectory() && dir.name.matches('\\d{8}_\\d{6}') | ||
| } as FileFilter) | ||
|
|
||
| if (timestampedDirs && timestampedDirs.length > 0) { | ||
| // Get the most recent directory | ||
| recordingDir = timestampedDirs.sort { it.name }.last() | ||
| } | ||
|
|
||
| and: 'Get all recording files (mp4 or flv)' | ||
| File[] recordingFiles = recordingDir?.listFiles({ File file -> | ||
| file.isFile() && (file.name.endsWith('.mp4') || file.name.endsWith('.flv')) && file.name.contains(this.class.getSimpleName()) | ||
| } as FileFilter) | ||
|
|
||
| then: 'recording directory should exist' | ||
| recordingDir != null | ||
| recordingDir.exists() | ||
|
|
||
| and: 'recording files should be created for each test method' | ||
| recordingFiles != null | ||
| recordingFiles.length >= 2 // At least 2 files for the first two test methods | ||
|
|
||
| and: 'recording files should have different content (different sizes)' | ||
| // Sort by last modified time to get the most recent files | ||
| File[] sortedFiles = recordingFiles.sort { it.lastModified() } | ||
| File secondLastFile = sortedFiles[sortedFiles.length - 2] | ||
| File lastFile = sortedFiles[sortedFiles.length - 1] | ||
|
|
||
| // Files should have different sizes (allowing for small variations due to timing) | ||
| long sizeDifference = Math.abs(lastFile.length() - secondLastFile.length()) | ||
| sizeDifference > 1000 // Expect at least 1KB difference | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.