Update to Asset Pipeline 5.0.16 #15040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure they pull the correct code
…coordinate change
jamesfredley
approved these changes
Sep 2, 2025
matrei
reviewed
Sep 3, 2025
| @@ -70,6 +70,7 @@ class CommandSpec extends Specification { | |||
| String[] args = builder.toString().split(' ') | |||
| ProcessBuilder pb = new ProcessBuilder(args) | |||
| pb.environment().put('JAVA_HOME', System.getenv('JAVA_HOME') ?: System.getProperty('java.home')) | |||
| pb.environment().put('GRAILS_REPO_URL', System.getenv('GRAILS_REPO_URL') ?: null) | |||
There was a problem hiding this comment.
From https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/ProcessBuilder.html#environment():
The returned map does not permit null keys or values. Attempting to insert or query the presence of a null key or value will throw a NullPointerException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #14953, since we depend on the asset pipeline, the coordinate change for grails-i18n broke forge. This should resolve it once 5.0.16 is findable on maven central.