Skip to content

Update to Asset Pipeline 5.0.16 #15040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

Update to Asset Pipeline 5.0.16 #15040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aea7854
fix - forge generated projects should use the local-maven repo to ens…
jdaugherty Sep 2, 2025
5f9acaa
deps - update to 5.0.16 for the asset pipeline to fix forge for i18n …
jdaugherty Sep 2, 2025
c724f15
remove i18n as default grails forge plugin
jdaugherty Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dependencies.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ ext {
'ant.version' : '1.10.15',
'asciidoctor-gradle-jvm.version': '4.0.5',
'asciidoctorj.version' : '3.0.0',
'asset-pipeline-gradle.version' : '5.0.15',
'asset-pipeline-gradle.version' : '5.0.16',
'byte-buddy.version' : '1.17.7',
'commons-text.version' : '1.13.1',
'directory-watcher.version' : '0.19.1',
Expand Down Expand Up @@ -72,7 +72,7 @@ ext {
]

bomDependencyVersions = [
'asset-pipeline-bom.version' : '5.0.15',
'asset-pipeline-bom.version' : '5.0.16',
'bootstrap-icons.version' : '1.13.1',
'bootstrap.version' : '5.3.7',
'commons-codec.version' : '1.18.0',
Expand Down
1 change: 1 addition & 0 deletions grails-forge/grails-forge-cli/src/test/groovy/org/grails/forge/cli/CommandSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ class CommandSpec extends Specification {
String[] args = builder.toString().split(' ')
ProcessBuilder pb = new ProcessBuilder(args)
pb.environment().put('JAVA_HOME', System.getenv('JAVA_HOME') ?: System.getProperty('java.home'))
pb.environment().put('GRAILS_REPO_URL', System.getenv('GRAILS_REPO_URL') ?: null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/ProcessBuilder.html#environment():
The returned map does not permit null keys or values. Attempting to insert or query the presence of a null key or value will throw a NullPointerException.

process = pb.directory(dir).start()
process.consumeProcessOutputStream(output)
process
Expand Down
2 changes: 1 addition & 1 deletion ...grails-forge-core/src/main/java/org/grails/forge/feature/grails/GrailsDefaultPlugins.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public boolean supports(ApplicationType applicationType) {

@Override
public void apply(GeneratorContext generatorContext) {
Arrays.asList("rest-transforms", "databinding", "i18n", "services", "url-mappings", "interceptors")
Arrays.asList("rest-transforms", "databinding", "services", "url-mappings", "interceptors")
.forEach((artifact) -> {
generatorContext.addDependency(Dependency.builder()
.groupId("org.apache.grails")
Expand Down
Loading