Backport: "HBASE-29448: Modern backup failures can cause backup system to lock up" #7317

hgromer · 2025-09-17T16:56:29Z

No description provided.

…k up

hgromer · 2025-09-24T19:10:08Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java

+      listSnapshots().stream().filter(s -> s.getName().equals(snapshotName)).findFirst()
+        .orElseThrow(() -> new IOException("Snapshot " + snapshotName + " not found"));
+    TableName tn = snapshot.getTableName();
+    disableTable(tn);


This is the same behavior as the logic we had in the BackupSystemTable that we're replacing. Does it makse sense to include this behavior? Or should this method do nothing by default?

Apache-HBase · 2025-09-24T20:11:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	buf	0m 1s		buf was not available.
+0 🆗	buf	0m 1s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 15s		branch-2 passed
+1 💚	compile	5m 35s		branch-2 passed
+1 💚	checkstyle	1m 50s		branch-2 passed
+1 💚	spotbugs	5m 37s		branch-2 passed
+1 💚	spotless	0m 48s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	5m 38s		the patch passed
+1 💚	cc	5m 38s		the patch passed
+1 💚	javac	5m 38s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 45s		the patch passed
+1 💚	spotbugs	6m 22s		the patch passed
+1 💚	hadoopcheck	16m 55s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚	hbaseprotoc	2m 3s		the patch passed
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		58m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7317
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux 5b330ee0c3a2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `6d32ea7`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-backup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-09-24T23:38:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 32s		branch-2 passed
+1 💚	compile	2m 34s		branch-2 passed
+1 💚	javadoc	1m 28s		branch-2 passed
+1 💚	shadedjars	6m 32s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 10s		the patch passed
+1 💚	compile	2m 38s		the patch passed
+1 💚	javac	2m 38s		the patch passed
+1 💚	javadoc	1m 24s		the patch passed
+1 💚	shadedjars	6m 26s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 31s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 6s		hbase-client in the patch passed.
+1 💚	unit	205m 3s		hbase-server in the patch passed.
+1 💚	unit	6m 49s		hbase-thrift in the patch passed.
+1 💚	unit	10m 37s		hbase-backup in the patch passed.
		265m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7317
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 9f650e840c22 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `6d32ea7`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/testReport/
Max. process+thread count	3557 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-backup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-09-24T23:49:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 44s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 55s		branch-2 passed
+1 💚	compile	2m 5s		branch-2 passed
+1 💚	javadoc	1m 25s		branch-2 passed
+1 💚	shadedjars	5m 43s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s		the patch passed
+1 💚	compile	2m 6s		the patch passed
+1 💚	javac	2m 6s		the patch passed
+1 💚	javadoc	1m 24s		the patch passed
+1 💚	shadedjars	5m 36s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 25s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	7m 54s		hbase-client in the patch passed.
+1 💚	unit	217m 57s		hbase-server in the patch passed.
+1 💚	unit	7m 23s		hbase-thrift in the patch passed.
+1 💚	unit	11m 10s		hbase-backup in the patch passed.
		276m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7317
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c17ef50a9b06 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `6d32ea7`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/testReport/
Max. process+thread count	3350 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-backup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-09-24T23:50:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 25s		branch-2 passed
+1 💚	compile	2m 28s		branch-2 passed
+1 💚	javadoc	1m 25s		branch-2 passed
+1 💚	shadedjars	6m 46s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 18s		the patch passed
+1 💚	compile	2m 30s		the patch passed
+1 💚	javac	2m 30s		the patch passed
+1 💚	javadoc	1m 22s		the patch passed
+1 💚	shadedjars	6m 46s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 32s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 7s		hbase-client in the patch passed.
+1 💚	unit	215m 58s		hbase-server in the patch passed.
+1 💚	unit	7m 2s		hbase-thrift in the patch passed.
+1 💚	unit	11m 22s		hbase-backup in the patch passed.
		277m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7317
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 7fc331655345 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `6d32ea7`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/testReport/
Max. process+thread count	3625 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-backup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

hgromer force-pushed the HBASE-29448-branch-2 branch from 32103e7 to fa21ea2 Compare September 17, 2025 16:57

hgromer changed the title ~~"HBase Backport: HBASE-29448: Modern backup failures can cause backup system to lock up"~~ Backport: "HBASE-29448: Modern backup failures can cause backup system to lock up" Sep 17, 2025

This comment has been minimized.

Sign in to view

PDavid mentioned this pull request Sep 18, 2025

HBASE-29609 Upgrade checkstyle and Maven checkstyle plugin to fix site build failure #7321

Merged

hgromer force-pushed the HBASE-29448-branch-2 branch 2 times, most recently from 5c6bcd3 to 8187004 Compare September 18, 2025 12:33

This comment has been minimized.

Sign in to view

hgromer force-pushed the HBASE-29448-branch-2 branch from 8187004 to 4ddbf5d Compare September 24, 2025 19:04

HBase Backport: Modern backup failures can cause backup system to loc…

6d32ea7

…k up

hgromer force-pushed the HBASE-29448-branch-2 branch from 4ddbf5d to 6d32ea7 Compare September 24, 2025 19:08

hgromer commented Sep 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Backport: "HBASE-29448: Modern backup failures can cause backup system to lock up" #7317

Backport: "HBASE-29448: Modern backup failures can cause backup system to lock up" #7317

hgromer commented Sep 17, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

hgromer Sep 24, 2025

Uh oh!

Apache-HBase commented Sep 24, 2025

Uh oh!

Apache-HBase commented Sep 24, 2025

Uh oh!

Apache-HBase commented Sep 24, 2025

Uh oh!

Apache-HBase commented Sep 24, 2025

Uh oh!

Uh oh!

Backport: "HBASE-29448: Modern backup failures can cause backup system to lock up" #7317

Are you sure you want to change the base?

Backport: "HBASE-29448: Modern backup failures can cause backup system to lock up" #7317

Conversation

hgromer commented Sep 17, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

hgromer Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Sep 24, 2025

Uh oh!

Apache-HBase commented Sep 24, 2025

Uh oh!

Apache-HBase commented Sep 24, 2025

Uh oh!

Apache-HBase commented Sep 24, 2025

Uh oh!

Uh oh!