Fix: Ensure metadata.seq >= max(doc.seq) to prevent concurrency bug in IndexedDB adapter #9093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a concurrency bug in the IndexedDB adapter where parallel
bulkDocs()transactions could result inmetadata.seqbeing lower than the highestdoc.seq, breaking replication logic.Fix
Tracks
maxSeqThisTxnduring the transaction and ensuresmetadata.seq = Math.max(metadata.seq, maxSeqThisTxn)before writing metadata.Test
Added integration test to
test.bulk_docs.js:bulkDocs()doc.seqvalues are unique and strictly increasingmetadata.seq >= max(doc.seq)Fix is minimal, scoped, and backward-compatible.