Skip to content

Fix: Ensure metadata.seq >= max(doc.seq) to prevent concurrency bug in IndexedDB adapter #9093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Ensure metadata.seq >= max(doc.seq) to prevent concurrency bug in IndexedDB adapter #9093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/node_modules/pouchdb-adapter-indexeddb/src/bulkDocs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
const rewriteEnabled = dbOpts.name.indexOf("-mrview-") === -1;
const autoCompaction = dbOpts.auto_compaction;

let maxSeqThisTxn = metadata.seq;

// We only need to track 1 revision for local documents
function docsRevsLimit(doc) {
return isLocalId(doc.id) ? 1 : revsLimit;
Expand Down Expand Up @@ -211,7 +213,9 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
// Bump the seq for every new (non local) revision written
if (!isLocal) {
doc.seq = ++metadata.seq;

if (doc.seq > maxSeqThisTxn) {
maxSeqThisTxn = doc.seq;
}
let delta = 0;
// If its a new document, we wont decrement if deleted
if (doc.isNewDoc) {
Expand Down Expand Up @@ -304,6 +308,7 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)

function updateSeq(i) {
if (i === lastWriteIndex) {
metadata.seq = Math.max(metadata.seq, maxSeqThisTxn);
txn.objectStore(META_LOCAL_STORE).put(metadata);
}
}
Expand Down