Skip to content

Make proportional font outputs work (when the MONO axis is set to <1) #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

arrowtype
Copy link
Owner

@arrowtype arrowtype commented Jun 23, 2023

Work to fix #24. More details in that issue.

  • fix normal glyph widths in proportional outputs
  • fix code ligature glyph widths in proportional outputs, if Code Ligatures: True is set in the config
  • get kerning working when Code Ligatures: True is set in the config

For proportional fonts, kerning (and other OT features) now remains, even though code ligatures are updated from the dlig to calt feature tag.

Unfortunately, I’ve now realized that more feature code than is ideal gets replaced in MONO=1 fonts, but that was the case before, and it is substantially harder to change there, because the feature code has to be more radically altered. That is a different issue, though (#26).

@arrowtype arrowtype mentioned this pull request Jun 23, 2023
@arrowtype
Copy link
Owner Author

As far as I can tell in my testing so far, this introduces only improvements, and no regressions. It may be slightly confusing that it changes the font family names from Rec Mono X to Rec Code X, however, and that these naming updates aren’t yet moved in the releases in the main Recursive project repo. So, I’ll wait until I’ve updated the main release before merging this.

If anyone wants proportional Rec Code fonts, however, the ones in this branch should be good to go!

@seankhl
Copy link

seankhl commented Aug 29, 2023

I used this branch to generate lighter-weight fonts (I find the defaults a bit to heavy), and so far it's working perfectly for me whereas with main I was having the same issues described in #24. Looking forward to seeing this merged and thanks for the beautiful and highly configurable font!

My only suggestion is to maybe tweak the naming so that if MONO is set to 0, the name isn't "Code" but maybe "Sans" or "UI" (in contrast to "Code") or something. But I get that this type of automagical behavior can be a bit confusing and hard to maintain... it's just that I am using the custom proportional fonts for UI rather than code so the naming is a bit off in my case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for proportional fonts
2 participants