add basic FITS HIPS coadd support #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
reviewed
Jun 30, 2025
reproject/hips/core.py
Outdated
| header = fits.getheader(filepath) | ||
| image1 = fits.getdata(filepath) | ||
| image2 = fits.getdata(target_filepath) | ||
| result = image1 + image2 |
There was a problem hiding this comment.
The problem with this is that as you get to the lower res tiles you will keep summing the fluxes so the effective flux will be much higher in the low res tiles. I think you want to take an average of the two here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title: allow for FITS HIPS coadding.
Problem: FITS HIPS doesn't display well right now, could use help: