Skip to content

add basic FITS HIPS coadd support #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: hips
Choose a base branch
from
Open

add basic FITS HIPS coadd support #4

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a302f80
add basic FITS HIPS coadd support
keflavich Jun 30, 2025
8f59b4b
average instead of straight adding
keflavich Jun 30, 2025
b6347ab
average instead of straight adding then dividing
keflavich Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion reproject/hips/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,14 @@ def coadd_hips(input_directories, output_directory):
raise NotImplementedError(
"Convert jpg to png to allow for blending/coadding"
)
elif tile_format == "fits":
header = fits.getheader(filepath)
image1 = fits.getdata(filepath)
image2 = fits.getdata(target_filepath)
result = image1 + image2
Copy link
Owner

@astrofrog astrofrog Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with this is that as you get to the lower res tiles you will keep summing the fluxes so the effective flux will be much higher in the low res tiles. I think you want to take an average of the two here.

Copy link
Author

@keflavich keflavich Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, makes sense!

fits.writeto(target_filepath, result, header, overwrite=True)
else:
raise NotImplementedError()
raise NotImplementedError(f"Tile format {tile_format} not implemented")
else:
shutil.copyfile(filepath, target_filepath)

Expand Down
Loading