Update Bazel dependencies and load rules for bazel 9 compatibility #424
+1,605
−707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Need #423 to be taken care of first anyway |
ted-xie
requested changes
Dec 3, 2025
Contributor
ted-xie
left a comment
ted-xie
left a comment
There was a problem hiding this comment.
Thank you for the PR! I left a few comments, but overall we can't accept submissions which change the ordering for things like attributes and starlark load()s, since the original ordering of the loads reflects the reality of our primary source of truth: the Google monorepo.
Other changes in this PR such as updating the dep versions and adding missing loads are greatly appreciated.
Author
|
I fixed all tests but non-arm macos (because it still doesn't have the new android tools) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.