feat(atmosphere): add sun_disc_mult to Atmosphere to control sun disc visibility (#20425) #20452
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a multiplier field to control sun disc visibility in the procedural atmosphere.
… visibility (bevyengine#20425) Adds a new `sun_disc_mult: f32` field to the Atmosphere component so users can toggle the sun disc in procedural sky rendering. Defaults to 1.0 (sun visible) and can be set to 0.0 to hide the disc. The default EARTH constant is updated to set `sun_disc_mult` to 1.0. This partially addresses bevyengine#20425.https://github.com/slopisgood/bevy/edit/slopisgood-patch-1/crates/bevy_pbr/src/atmosphere/mod.rs
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Adds sun_disc_mult field to the Atmosphere struct in WGSL so that it matches the Rust component. Allows toggling visibility of the sun disc. (bevyengine#20425)
|
These changes don't appear to do anything and seem to be possibly vibecoded? |
alice-i-cecile
added
A-Rendering
|
Closing per bevyengine/bevy-website#2204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
sun_disc_mult: f32field to theAtmospherecomponent to control the visibility of the procedural sun disc.sun_disc_mult, a multiplier on the direct sun disc radiance. The default value is1.0, which shows the disc. Setting it to0.0hides the disc while still scattering the sun's radiance into the sky.pub sun_disc_mult: f32to theAtmospherestruct with documentation.EARTHconstant to setsun_disc_mult: 1.0.This allows applications to disable the sun disc when baking sky lighting. Closes #20425.