-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add StartMainPassPostProcessing node for ordering #20939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(Node3d::EndMainPass, NodePbr::VolumetricFog, Node3d::Bloom), | ||
( | ||
Node3d::EndMainPass, | ||
NodePbr::VolumetricFog, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like maybe this should be ordered before EndMainPass if it's considered to be part of the main pass? I'm just not sure where it should go. I guess this works well enough though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think its considered to be part of the main pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was 100% basing this based on the comment that was above 😅.
Needs migration guide imo |
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
I dont believe this needs a migration guide, theres no breaking change here |
Should the bevy/crates/bevy_post_process/src/bloom/mod.rs Lines 81 to 85 in ec735b9
|
Controvesial: all of the post processing nodes should be moved to a |
the issue with moving it out is that you then need to depend on bevy_post_processing to order relative to post processing. we really just need a better more powerful render graph abstraction, id like to land this fix and figure that out next cycle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ordering of volumetric fog does feel a bit weird since it's supposed to be at the start of post processing but is ordered before the new label. This is more of an issue with the render graph abstraction though.
Objective
InvalidNode(Bloom)
crash ifbevy_post_process
is off #20923Solution
Testing