Skip to content

Remove line_height from TextFont #21180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove line_height from TextFont #21180

wants to merge 4 commits into from
+188 −79

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Sep 23, 2025 •
edited
Loading

Objective

Remove the line_height field from TextFont.
Line height is a property of the text layout, not the font.

Part of the changes for #21175

Solution

Remove the line_height field from TextFont.
Make LineHeight into a component.
Update the text access API and text pipeline.

@TimJentzsch TimJentzsch added C-Code-Quality A section of code that is hard to understand or change A-Text Rendering and layout for characters S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Text Rendering and layout for characters C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ickshonpe @TimJentzsch