Send the entire loaded asset instead of decomposing it on the loader task. #21204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
InternalAssetEvent::Loaded
for every root asset and each of its subassets. Thehandle_internal_asset_events
system reads these events one at a time. This means these two threads are racing. So it's possible to see some of the subassets loaded without the root asset being loaded in a frame, and then have to wait an additional frame to see the remaining subassets and root asset loaded.Solution
LoadedAsset
in its entirety.Testing
handle_internal_asset_events
needs to finish the last received subasset before the loader task sends the root asset. This is probably pretty unlikely, but could in theory cause flaky tests.