Fix crash with RenderDiagnosticsPlugin on mac #21238
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeophlite
approved these changes
Sep 28, 2025
Zeophlite
added
C-Bug
|
Pinging @jf908 who introduced the relevant lines :) |
|
Probably |
alice-i-cecile
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Sep 28, 2025
mockersf
pushed a commit
that referenced
this pull request
Sep 28, 2025
# Objective - Fixes #21167 (happens with `trace_tracy` feature too, as it adds the plugin automatically) - There are some uses of `time_span` inside passes, which go around [the check](https://github.com/bevyengine/bevy/blob/10325593d5bae88e1089bdf1fa1395f232d5248b/crates/bevy_render/src/diagnostic/internal.rs#L289) for [TIMESTAMP_QUERY_INSIDE_PASSES](https://docs.rs/wgpu-types/latest/wgpu_types/struct.FeaturesWGPU.html#associatedconstant.TIMESTAMP_QUERY_INSIDE_PASSES) feature (unsupported on Apple GPU). introduced in #19191 ## Solution - They look like just typos (all in `let pass_span = time_span` form), so replaced with `pass_span`. There's an occurence of this pattern in `meshlet/visibility_buffer_raster_node.rs`, but it's the variable name that seems incorrect in this case. I renamed it instead. ## Testing - Running `log_diagnostics` example no longer crashes on Mac.
mockersf
pushed a commit
that referenced
this pull request
Sep 28, 2025
# Objective - Fixes #21167 (happens with `trace_tracy` feature too, as it adds the plugin automatically) - There are some uses of `time_span` inside passes, which go around [the check](https://github.com/bevyengine/bevy/blob/10325593d5bae88e1089bdf1fa1395f232d5248b/crates/bevy_render/src/diagnostic/internal.rs#L289) for [TIMESTAMP_QUERY_INSIDE_PASSES](https://docs.rs/wgpu-types/latest/wgpu_types/struct.FeaturesWGPU.html#associatedconstant.TIMESTAMP_QUERY_INSIDE_PASSES) feature (unsupported on Apple GPU). introduced in #19191 ## Solution - They look like just typos (all in `let pass_span = time_span` form), so replaced with `pass_span`. There's an occurence of this pattern in `meshlet/visibility_buffer_raster_node.rs`, but it's the variable name that seems incorrect in this case. I renamed it instead. ## Testing - Running `log_diagnostics` example no longer crashes on Mac.
|
Sorry I didn't get to this in time, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
RenderDiagnosticsPlugin#21167(happens with
trace_tracyfeature too, as it adds the plugin automatically)time_spaninside passes, which go around the check for TIMESTAMP_QUERY_INSIDE_PASSES feature (unsupported on Apple GPU).introduced in Record render diagnostics for all engine passes #19191
Solution
let pass_span = time_spanform), so replaced withpass_span.There's an occurence of this pattern in
meshlet/visibility_buffer_raster_node.rs, but it's the variable name that seems incorrect in this case. I renamed it instead.Testing
log_diagnosticsexample no longer crashes on Mac.