Refactor CanonicalIter to return CanonicalTxNode #2063
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the CanonicalIter iterator in bdk_chain to return a structured CanonicalTxNode instead of a raw (txid, tx, reason) tuple. The new struct encapsulates the transaction ID, full transaction data, and canonicalization reason, improving clarity and aligning with the TODO comment in canonical_view.rs.
This change is purely type-level and does not alter the behavior of the canonicalization algorithm. All existing logic and control flow are preserved.
Notes to the reviewers
Changelog notice
Refactor: CanonicalIter now returns a CanonicalTxNode instead of a tuple. This improves type clarity and aligns with internal TODOs. No behavior changes.
Checklists
All Submissions:
New Features:
Bugfixes: